chore(coderd/autobuild): use dbtestutil.WillUsePostgres instead of os.Getenv in test (coder#18145)

hugodutka · web-flow · commit d3ed6fe6521a · 2025-06-02T13:58:07.000+02:00
Standardizing on `WillUsePostgres` will make it easier to remove the check entirely once dbmem is removed. Related to coder#15109.
diff --git a/coderd/autobuild/lifecycle_executor_test.go b/coderd/autobuild/lifecycle_executor_test.go
@@ -2,7 +2,6 @@ package autobuild_test
 
 import (
 	"context"
-	"os"
 	"testing"
 	"time"
 
@@ -741,7 +740,7 @@ func TestExecutorWorkspaceAutostopNoWaitChangedMyMind(t *testing.T) {
 }
 
 func TestExecutorAutostartMultipleOK(t *testing.T) {
-	if os.Getenv("DB") == "" {
+	if !dbtestutil.WillUsePostgres() {
 		t.Skip(`This test only really works when using a "real" database, similar to a HA setup`)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@ package autobuild_test`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
`5`		`- "os"`
`6`	`5`	`"testing"`
`7`	`6`	`"time"`
`8`	`7`
`@@ -741,7 +740,7 @@ func TestExecutorWorkspaceAutostopNoWaitChangedMyMind(t *testing.T) {`
`741`	`740`	`}`
`742`	`741`
`743`	`742`	`func TestExecutorAutostartMultipleOK(t *testing.T) {`
`744`		`- if os.Getenv("DB") == "" {`
	`743`	`+ if !dbtestutil.WillUsePostgres() {`
`745`	`744`	t.Skip(`This test only really works when using a "real" database, similar to a HA setup`)
`746`	`745`	`}`
`747`	`746`