-
Notifications
You must be signed in to change notification settings - Fork 2
Expand file tree
/
Copy pathanalysis_test.go
More file actions
335 lines (309 loc) · 8.65 KB
/
Copy pathanalysis_test.go
File metadata and controls
335 lines (309 loc) · 8.65 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
package gbash_test
import (
"context"
"io"
"os"
"path/filepath"
"strings"
"sync"
"testing"
"github.com/ewhauser/gbash"
"github.com/ewhauser/gbash/shell/analysis"
"github.com/ewhauser/gbash/shell/syntax"
)
type analysisRecord struct {
event analysis.Event
run analysis.RunMetadata
file analysis.FileMetadata
stmt *syntax.Stmt
cmd syntax.Command
scopes []analysis.Scope
options analysis.Options
control analysis.ControlFlow
source string
}
type analysisRecorder struct {
mu sync.Mutex
events []analysisRecord
}
func (r *analysisRecorder) Observe(ctx analysis.Context, event analysis.Event) {
record := analysisRecord{
event: event,
run: ctx.Run(),
file: ctx.File(),
stmt: ctx.Statement(),
cmd: ctx.Command(),
scopes: ctx.Scopes(),
options: ctx.Options(),
control: ctx.ControlFlow(),
}
switch {
case record.cmd != nil:
record.source = strings.TrimSpace(ctx.Source(record.cmd))
case record.stmt != nil:
record.source = strings.TrimSpace(ctx.Source(record.stmt))
}
r.mu.Lock()
defer r.mu.Unlock()
r.events = append(r.events, record)
}
func (r *analysisRecorder) snapshot() []analysisRecord {
r.mu.Lock()
defer r.mu.Unlock()
out := make([]analysisRecord, len(r.events))
copy(out, r.events)
return out
}
func TestAnalysisObserverReportsShellSemantics(t *testing.T) {
t.Parallel()
root := t.TempDir()
if err := os.WriteFile(filepath.Join(root, "helper.sh"), []byte("helper_var=2\necho \"$helper_var\" >/dev/null\n"), 0o644); err != nil {
t.Fatalf("WriteFile() error = %v", err)
}
recorder := &analysisRecorder{}
rt, err := gbash.New(
gbash.WithWorkspace(root),
gbash.WithAnalysisObserver(recorder),
)
if err != nil {
t.Fatalf("New() error = %v", err)
}
script := strings.Join([]string{
"set -e",
"foo=1",
"echo \"$foo\" >/dev/null",
"f() { local bar=\"$foo\"; unset foo; echo \"$bar\" >/dev/null; }",
"f",
"source helper.sh",
"eval 'qux=4; echo \"$qux\" >/dev/null'",
"echo left | cat >/dev/null",
"(echo sub >/dev/null)",
"false || true",
"",
}, "\n")
result, err := rt.Run(context.Background(), &gbash.ExecutionRequest{
Name: "analysis.sh",
Script: script,
})
if err != nil {
t.Fatalf("Run() error = %v", err)
}
if got, want := result.ExitCode, 0; got != want {
t.Fatalf("ExitCode = %d, want %d", got, want)
}
events := recorder.snapshot()
if countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunStart)
return ok
}) != 1 {
t.Fatalf("RunStart count = %d, want 1", countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunStart)
return ok
}))
}
if countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunFinish)
return ok
}) != 1 {
t.Fatalf("RunFinish count = %d, want 1", countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunFinish)
return ok
}))
}
if countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.StatementEnter)
return ok
}) == 0 || countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.StatementExit)
return ok
}) == 0 {
t.Fatalf("missing statement lifecycle events: %#v", events)
}
if countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.CommandEnter)
return ok
}) == 0 || countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.CommandExit)
return ok
}) == 0 {
t.Fatalf("missing command lifecycle events: %#v", events)
}
fileStartCount := countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.FileStart)
return ok
})
fileFinishCount := countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.FileFinish)
return ok
})
if fileStartCount < 3 || fileFinishCount < 3 {
t.Fatalf("file lifecycle counts = (%d,%d), want at least 3",
fileStartCount,
fileFinishCount,
)
}
scopeKinds := map[analysis.ScopeKind]bool{}
for _, event := range events {
scopeEnter, ok := event.event.(analysis.ScopeEnter)
if !ok {
continue
}
scopeKinds[scopeEnter.Scope.Kind] = true
}
for _, kind := range []analysis.ScopeKind{
analysis.ScopeFunction,
analysis.ScopeSource,
analysis.ScopeEval,
analysis.ScopeSubshell,
analysis.ScopePipeline,
} {
if !scopeKinds[kind] {
t.Fatalf("missing scope kind %q in %#v", kind, scopeKinds)
}
}
writes := observedVariableNames(events, "write")
for _, name := range []string{"foo", "bar", "helper_var", "qux"} {
if !writes[name] {
t.Fatalf("missing variable write for %q in %#v", name, writes)
}
}
reads := observedVariableNames(events, "read")
for _, name := range []string{"foo", "bar", "helper_var", "qux"} {
if !reads[name] {
t.Fatalf("missing variable read for %q in %#v", name, reads)
}
}
unsets := observedVariableNames(events, "unset")
if !unsets["foo"] {
t.Fatalf("missing variable unset for foo in %#v", unsets)
}
suppressed := false
for _, event := range events {
if _, ok := event.event.(analysis.CommandExit); !ok {
continue
}
if event.source == "false" && event.options.Errexit && event.control.ErrExitSuppressed {
suppressed = true
break
}
}
if !suppressed {
t.Fatal("missing set -e suppressed command exit for `false || true`")
}
}
func TestAnalysisObserverReportsChunkedFileBoundaries(t *testing.T) {
t.Parallel()
recorder := &analysisRecorder{}
rt, err := gbash.New(gbash.WithAnalysisObserver(recorder))
if err != nil {
t.Fatalf("New() error = %v", err)
}
result, err := rt.Run(context.Background(), &gbash.ExecutionRequest{
Name: "chunks.sh",
Script: "echo one\necho two\n",
})
if err != nil {
t.Fatalf("Run() error = %v", err)
}
if got, want := result.ExitCode, 0; got != want {
t.Fatalf("ExitCode = %d, want %d", got, want)
}
var files []analysis.FileMetadata
for _, event := range recorder.snapshot() {
if _, ok := event.event.(analysis.FileStart); ok {
files = append(files, event.file)
}
}
if got, want := len(files), 2; got != want {
t.Fatalf("len(FileStart) = %d, want %d", got, want)
}
if got, want := files[0].ChunkIndex, 0; got != want {
t.Fatalf("first ChunkIndex = %d, want %d", got, want)
}
if got, want := files[1].ChunkIndex, 1; got != want {
t.Fatalf("second ChunkIndex = %d, want %d", got, want)
}
if got, want := files[0].ChunkLine, uint(1); got != want {
t.Fatalf("first ChunkLine = %d, want %d", got, want)
}
if got, want := files[1].ChunkLine, uint(2); got != want {
t.Fatalf("second ChunkLine = %d, want %d", got, want)
}
}
func TestAnalysisObserverRunsForInteractiveShells(t *testing.T) {
t.Parallel()
recorder := &analysisRecorder{}
rt, err := gbash.New(gbash.WithAnalysisObserver(recorder))
if err != nil {
t.Fatalf("New() error = %v", err)
}
session, err := rt.NewSession(context.Background())
if err != nil {
t.Fatalf("NewSession() error = %v", err)
}
result, err := session.Interact(context.Background(), &gbash.InteractiveRequest{
Stdin: strings.NewReader("echo hi\n"),
Stdout: io.Discard,
Stderr: io.Discard,
})
if err != nil {
t.Fatalf("Interact() error = %v", err)
}
if got, want := result.ExitCode, 0; got != want {
t.Fatalf("ExitCode = %d, want %d", got, want)
}
events := recorder.snapshot()
if countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunStart)
return ok
}) != 1 {
t.Fatalf("RunStart count = %d, want 1", countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunStart)
return ok
}))
}
if countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunFinish)
return ok
}) != 1 {
t.Fatalf("RunFinish count = %d, want 1", countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.RunFinish)
return ok
}))
}
if countAnalysisEvents(events, func(event analysis.Event) bool {
_, ok := event.(analysis.CommandEnter)
return ok
}) == 0 {
t.Fatalf("missing command events for interactive shell: %#v", events)
}
}
func countAnalysisEvents(events []analysisRecord, match func(analysis.Event) bool) int {
count := 0
for i := range events {
if match(events[i].event) {
count++
}
}
return count
}
func observedVariableNames(events []analysisRecord, kind string) map[string]bool {
out := map[string]bool{}
for i := range events {
switch value := events[i].event.(type) {
case analysis.VariableRead:
if kind == "read" {
out[value.Name] = true
}
case analysis.VariableWrite:
if kind == "write" {
out[value.Name] = true
}
case analysis.VariableUnset:
if kind == "unset" {
out[value.Name] = true
}
}
}
return out
}