Merge pull request #906 from sophiedophie/bugfix/exclude-infinity-from-number

guyonroche · web-flow · commit ff813aa0aa28 · 2019-10-02T17:36:57.000+01:00
Exclude Infinity on createInputStream
diff --git a/lib/csv/csv.js b/lib/csv/csv.js
@@ -60,7 +60,7 @@ CSV.prototype = {
           return null;
         }
         const datumNumber = Number(datum);
-        if (!Number.isNaN(datumNumber)) {
+        if (!Number.isNaN(datumNumber) && datumNumber !== Infinity) {
           return datumNumber;
         }
         const dt = dayjs(datum, dateFormats, true);
diff --git a/spec/unit/xlsx/xform/sheet/cell-xform.spec.js b/spec/unit/xlsx/xform/sheet/cell-xform.spec.js
@@ -99,6 +99,38 @@ const expectations = [
     tests: ['prepare', 'render', 'renderIn', 'parse', 'reconcile'],
     options: {hyperlinkMap: fakeHyperlinkMap, styles: fakeStyles},
   },
+  {
+    title: 'String with Invalid Number',
+    create() {
+      return new CellXform();
+    },
+    initialModel: {
+      address: 'A1',
+      type: Enums.ValueType.String,
+      value: '6E1000',
+    },
+    preparedModel: {
+      address: 'A1',
+      type: Enums.ValueType.String,
+      value: '6E1000',
+    },
+    xml: '<c r="A1" t="str"><v>6E1000</v></c>',
+    parsedModel: {
+      address: 'A1',
+      type: Enums.ValueType.String,
+      value: '6E1000',
+    },
+    reconciledModel: {
+      address: 'A1',
+      type: Enums.ValueType.String,
+      value: '6E1000',
+    },
+    tests: ['prepare', 'render', 'renderIn', 'parse', 'reconcile'],
+    options: {
+      hyperlinkMap: fakeHyperlinkMap,
+      styles: fakeStyles,
+    },
+  },
   {
     title: 'Inline String with plain text',
     create() {

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ CSV.prototype = {`
`60`	`60`	`return null;`
`61`	`61`	`}`
`62`	`62`	`const datumNumber = Number(datum);`
`63`		`- if (!Number.isNaN(datumNumber)) {`
	`63`	`+ if (!Number.isNaN(datumNumber) && datumNumber !== Infinity) {`
`64`	`64`	`return datumNumber;`
`65`	`65`	`}`
`66`	`66`	`const dt = dayjs(datum, dateFormats, true);`