Merge pull request argotorg#4163 from sifmelcara/fix-visibility-assert

chriseth · web-flow · commit e97f9b6ba85b · 2018-05-21T10:12:50.000+02:00
Fix assert message about function visibility
diff --git a/libsolidity/ast/AST.cpp b/libsolidity/ast/AST.cpp
@@ -312,7 +312,7 @@ FunctionTypePointer FunctionDefinition::functionType(bool _internal) const
 		case Declaration::Visibility::External:
 			return {};
 		default:
-			solAssert(false, "visibility() should not return a Visibility");
+			solAssert(false, "visibility() should return a Visibility");
 		}
 	}
 	else
@@ -328,7 +328,7 @@ FunctionTypePointer FunctionDefinition::functionType(bool _internal) const
 		case Declaration::Visibility::External:
 			return make_shared<FunctionType>(*this, _internal);
 		default:
-			solAssert(false, "visibility() should not return a Visibility");
+			solAssert(false, "visibility() should return a Visibility");
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ FunctionTypePointer FunctionDefinition::functionType(bool _internal) const`
`312`	`312`	`case Declaration::Visibility::External:`
`313`	`313`	`return {};`
`314`	`314`	`default:`
`315`		`- solAssert(false, "visibility() should not return a Visibility");`
	`315`	`+ solAssert(false, "visibility() should return a Visibility");`
`316`	`316`	`}`
`317`	`317`	`}`
`318`	`318`	`else`
`@@ -328,7 +328,7 @@ FunctionTypePointer FunctionDefinition::functionType(bool _internal) const`
`328`	`328`	`case Declaration::Visibility::External:`
`329`	`329`	`return make_shared<FunctionType>(*this, _internal);`
`330`	`330`	`default:`
`331`		`- solAssert(false, "visibility() should not return a Visibility");`
	`331`	`+ solAssert(false, "visibility() should return a Visibility");`
`332`	`332`	`}`
`333`	`333`	`}`
`334`	`334`