elasticsearch safe_reboot no longer just runs_once

robyoung · mattbostock · commit fd7f8156e919 · 2015-07-27T17:00:35.000+01:00
With a more robust `wait_for_status` and given that `safe_reboot` waits
for the cluster to be green, we can now run `safe_reboot` over an
elasticsearch cluster with something like:

`fab staging puppet_class:govuk::node::s_api_elasticsearch elasticsearch.safe_reboot`
diff --git a/elasticsearch.py b/elasticsearch.py
@@ -95,7 +95,6 @@ def wait_for_status(*allowed):
 
 @task
 @serial
-@runs_once
 def safe_reboot():
     """Reboot only if the cluster is currently green"""
     import vm
@@ -112,12 +111,16 @@ def safe_reboot():
         # Give the reboot time to start, before we check for the status again.
         sleep(10)
 
-        # Status won't usually go back to green while reallocation is turned off,
-        # but should go to yellow.
+        # Status won't usually go back to green while reallocation is turned
+        # off, but should go to yellow.
         wait_for_status("green", "yellow")
         enable_reallocation()
     except:
-        print "Failed to re-enable allocation - you will need to enable it again using the 'elasticsearch.enable_reallocation' fabric command"
+        print(
+            "Failed to re-enable allocation - "
+            "you will need to enable it again using the "
+            "'elasticsearch.enable_reallocation' fabric command"
+        )
         raise
 
 
