Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 16, 2022. It is now read-only.

make formats for configuration-block configurable #16

Closed
dbu opened this issue Jul 20, 2014 · 4 comments
Closed

make formats for configuration-block configurable #16

dbu opened this issue Jul 20, 2014 · 4 comments

Comments

@dbu
Copy link
Contributor

dbu commented Jul 20, 2014

I love the tabbed configuration blocks from the symfony doc. i would love to reuse the same in the FOSHttpCache doc for varnish 3 vs varnish 4 configuration. there we use a literalinclude.

Any chance the configuration-block could be extended to support those two things? (configurable tab types and literalinclude)
@dbu dbu mentioned this issue Aug 25, 2014
Closed
@xabbuh xabbuh mentioned this issue Oct 3, 2014
Merged
@xabbuh
Copy link
Contributor

xabbuh commented Oct 3, 2014

see #20 for the configurable tab types

@xabbuh
Copy link
Contributor

xabbuh commented Oct 16, 2014

Using literalinclude does actually work. However, with the current implementation, the language to highlight MUST be specified explicitly. Is that sufficient or would it be better to derive it from the configured default language?

@dbu
Copy link
Contributor Author

dbu commented Oct 20, 2014

i can live with that. if it would fall back to the default but would be
possible to still include other fragments too and overwrite the language
explicitly, that would be fancy of course. but its totally good enough
like this.

@xabbuh
Copy link
Contributor

xabbuh commented Oct 21, 2014

#24 makes the language to be used with the literalinclude directive optional in configuration blocks.

@fabpot fabpot closed this as completed Oct 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @dbu @xabbuh