From 53911d3d85d42ff03feacaf8b692e9f24dfc4cd9 Mon Sep 17 00:00:00 2001 From: Jimmy Leger Date: Tue, 28 Dec 2010 19:37:57 -0800 Subject: [PATCH] [DoctrineBundle] DoctrineConverter::find($class, $request) and DoctrineConverter::findOneBy($class, $request) should return null --- .../Request/ParamConverter/DoctrineConverter.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Bundle/DoctrineBundle/Request/ParamConverter/DoctrineConverter.php b/src/Symfony/Bundle/DoctrineBundle/Request/ParamConverter/DoctrineConverter.php index 23bc249e7281e..44220ea852244 100644 --- a/src/Symfony/Bundle/DoctrineBundle/Request/ParamConverter/DoctrineConverter.php +++ b/src/Symfony/Bundle/DoctrineBundle/Request/ParamConverter/DoctrineConverter.php @@ -43,9 +43,9 @@ public function apply(Request $request, \ReflectionParameter $parameter) $class = $parameter->getClass()->getName(); // find by identifier? - if (false === $object = $this->find($class, $request)) { + if (null === $object = $this->find($class, $request)) { // find by criteria - if (false === $object = $this->findOneBy($class, $request)) { + if (null === $object = $this->findOneBy($class, $request)) { throw new \LogicException('Unable to guess how to get a Doctrine instance from the request information.'); } }