Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Get rid of Node 6 support#8455

Merged
SimenB merged 8 commits into
jestjs:nextfrom
Connormiha:get-rid-of-node6
Aug 19, 2019
Merged

Get rid of Node 6 support#8455
SimenB merged 8 commits into
jestjs:nextfrom
Connormiha:get-rid-of-node6

Conversation

@Connormiha

Copy link
Copy Markdown
Contributor

Summary

Nodejs team stop support of node 6 since 30 april.
I propose to remove support for node 6.
Many projects have already removed support of this version. For example Angular, Webpack 5 alpha, ts-loader.

Also i removed polyfill for v8.serialize because it supports since node 8

Test plan

Comment thread .circleci/config.yml
Comment thread package.json
@SimenB

SimenB commented May 11, 2019

Copy link
Copy Markdown
Member

I like it! @scotthovestadt are we gonna make any more 24 releases, or can we start breaking things?

@codecov-io

codecov-io commented May 12, 2019

Copy link
Copy Markdown

Codecov Report

Merging #8455 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8455      +/-   ##
==========================================
- Coverage   63.46%   63.38%   -0.09%     
==========================================
  Files         274      274              
  Lines       11385    11341      -44     
  Branches     2771     2760      -11     
==========================================
- Hits         7226     7188      -38     
+ Misses       3546     3541       -5     
+ Partials      613      612       -1
Impacted Files Coverage Δ
packages/jest-util/src/deepCyclicCopy.ts 100% <ø> (+17.64%) ⬆️
packages/jest-serializer/src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76f01b...c46a83d. Read the comment docs.

@SimenB

SimenB commented Jul 17, 2019

Copy link
Copy Markdown
Member

@SimenB

SimenB commented Jul 23, 2019

Copy link
Copy Markdown
Member

Two failing snapshots due to changed stack trace (removed async await transpilation, I guess). Mind updating them? 🙂

@Connormiha

Copy link
Copy Markdown
Contributor Author

@SimenB Done

@merlinnot

Copy link
Copy Markdown

One of the CI steps is failing as the process runs out of memory. As far as I can see there's 4096 MBs available in CircleCI, so we can bump it a little: NODE_OPTIONS=--max_old_space_size=4096. Obviously there are some other processes and the operating system consuming some memory too, so we'll never reach 4096, but this setting will allow all remaining memory to be consumed.

@Connormiha

Copy link
Copy Markdown
Contributor Author

One of the CI steps is failing as the process runs out of memory. As far as I can see there's 4096 MBs available in CircleCI, so we can bump it a little: NODE_OPTIONS=--max_old_space_size=4096. Obviously there are some other processes and the operating system consuming some memory too, so we'll never reach 4096, but this setting will allow all remaining memory to be consumed.

This test fails on master for a long time.

Comment thread packages/jest-serializer/src/index.ts
@SimenB SimenB changed the base branch from master to next August 19, 2019 09:19
@SimenB SimenB merged commit 4832947 into jestjs:next Aug 19, 2019
SimenB pushed a commit that referenced this pull request Aug 19, 2019
thymikee pushed a commit to SimenB/jest that referenced this pull request Aug 19, 2019
@jeysal jeysal removed this from the Jest 26 milestone Jan 22, 2020
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants