Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert ReactFreshMultipleRenderer to createRoot #28000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

Convert ReactFreshMultipleRenderer to createRoot #28000

merged 1 commit into from
Jan 19, 2024
+7 −3

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 19, 2024

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 19, 2024
@react-sizebot
Copy link

Comparing: feed8f3...51b56db

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.24 kB 176.24 kB = 54.88 kB 54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.34 kB 178.34 kB = 55.52 kB 55.53 kB
facebook-www/ReactDOM-prod.classic.js = 571.94 kB 571.94 kB = 100.56 kB 100.56 kB
facebook-www/ReactDOM-prod.modern.js = 555.70 kB 555.70 kB = 97.62 kB 97.62 kB
test_utils/ReactAllWarnings.js Deleted 67.55 kB 0.00 kB Deleted 16.54 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 67.55 kB 0.00 kB Deleted 16.54 kB 0.00 kB

Generated by 🚫 dangerJS against 51b56db

@eps1lon eps1lon marked this pull request as ready for review January 19, 2024 11:36
rickhanlonii
rickhanlonii approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy

@eps1lon eps1lon merged commit 4c58fc2 into facebook:main Jan 19, 2024
@eps1lon eps1lon deleted the test/create-root/ReactFreshMultipleRenderer branch January 19, 2024 17:25
@gnoff gnoff mentioned this pull request Feb 1, 2024
Merged
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
@sgnobst
Copy link

sgnobst commented Aug 12, 2025

✨ AI Code Review Complete

Great job! No significant issues found in the 1 files reviewed.

📊 Summary:

  • Files reviewed: 1
  • Files skipped: 0
  • Review status: ✅ All checks passed

1 similar comment
@sgnobst
Copy link

sgnobst commented Aug 12, 2025

✨ AI Code Review Complete

Great job! No significant issues found in the 1 files reviewed.

📊 Summary:

  • Files reviewed: 1
  • Files skipped: 0
  • Review status: ✅ All checks passed

@sgnobst
Copy link

sgnobst commented Aug 12, 2025

🤖 AI 코드 리뷰 완료

✅ 리뷰 결과

모든 검토가 완료되었으며, 심각한 이슈는 발견되지 않았습니다.

📊 리뷰 통계

항목 수치
📝 검토된 파일 1개
⏭️ 건너뛴 파일 0개
✅ 검토 상태 정상 완료

Reviewed by Azure OpenAI (2025-08-12 18:22)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eps1lon @react-sizebot @sgnobst @rickhanlonii @facebook-github-bot