Fix error when config keys arent included (async-aws#1171)

Jefemy · web-flow · commit 4aafa6bf7f35 · 2022-01-27T14:37:44.000+01:00
* Fix error when config keys arent included

* remove null fallback
diff --git a/src/Integration/Laravel/Filesystem/src/AsyncAwsFilesystemManager.php b/src/Integration/Laravel/Filesystem/src/AsyncAwsFilesystemManager.php
@@ -17,9 +17,9 @@ class AsyncAwsFilesystemManager extends FilesystemManager
     public function createAsyncAwsS3Driver(array $config)
     {
         $s3Config = [];
-        if ($config['key'] && $config['secret']) {
-            $s3Config['accessKeyId'] = $config['key'] ?? null;
-            $s3Config['accessKeySecret'] = $config['secret'] ?? null;
+        if (!empty($config['key']) && !empty($config['secret'])) {
+            $s3Config['accessKeyId'] = $config['key'];
+            $s3Config['accessKeySecret'] = $config['secret'];
             $s3Config['sessionToken'] = $config['token'] ?? null;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,9 @@ class AsyncAwsFilesystemManager extends FilesystemManager`
`17`	`17`	`public function createAsyncAwsS3Driver(array $config)`
`18`	`18`	`{`
`19`	`19`	`$s3Config = [];`
`20`		`- if ($config['key'] && $config['secret']) {`
`21`		`- $s3Config['accessKeyId'] = $config['key'] ?? null;`
`22`		`- $s3Config['accessKeySecret'] = $config['secret'] ?? null;`
	`20`	`+ if (!empty($config['key']) && !empty($config['secret'])) {`
	`21`	`+ $s3Config['accessKeyId'] = $config['key'];`
	`22`	`+ $s3Config['accessKeySecret'] = $config['secret'];`
`23`	`23`	`$s3Config['sessionToken'] = $config['token'] ?? null;`
`24`	`24`	`}`
`25`	`25`