minor symfony#51117 Remove \ReflectionProperty::setAccessible(true) calls (fancyweb)

nicolas-grekas · nicolas-grekas · commit 56f01c45727f · 2023-07-26T19:17:04.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- Remove \ReflectionProperty::setAccessible(true) calls | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 9e78833 Remove \ReflectionProperty::setAccessible(true) calls
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
@@ -168,7 +168,6 @@ public function testFilterDuplicateTransPaths()
         $command = $this->createMock(TranslationUpdateCommand::class);
 
         $method = new \ReflectionMethod(TranslationUpdateCommand::class, 'filterDuplicateTransPaths');
-        $method->setAccessible(true);
 
         $filteredTransPaths = $method->invoke($command, $transPaths);
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SerializerTest.php
@@ -44,7 +44,6 @@ public function testNormalizersAndEncodersUseDefaultContextConfigOption(string $
 
         $reflectionObject = new \ReflectionObject($normalizer);
         $property = $reflectionObject->getProperty('defaultContext');
-        $property->setAccessible(true);
 
         $defaultContext = $property->getValue($normalizer);
 
diff --git a/src/Symfony/Component/Config/Builder/ConfigBuilderGenerator.php b/src/Symfony/Component/Config/Builder/ConfigBuilderGenerator.php
@@ -589,7 +589,6 @@ private function hasNormalizationClosures(NodeInterface $node): bool
         } catch (\ReflectionException) {
             return false;
         }
-        $r->setAccessible(true);
 
         return [] !== $r->getValue($node);
     }
diff --git a/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php b/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
@@ -348,7 +348,6 @@ private function getListenersWithPriority(): array
         $result = [];
 
         $allListeners = new \ReflectionProperty(EventDispatcher::class, 'listeners');
-        $allListeners->setAccessible(true);
 
         foreach ($allListeners->getValue($this->dispatcher) as $eventName => $listenersByPriority) {
             foreach ($listenersByPriority as $priority => $listeners) {
diff --git a/src/Symfony/Component/Mailer/Tests/Transport/RoundRobinTransportTest.php b/src/Symfony/Component/Mailer/Tests/Transport/RoundRobinTransportTest.php
@@ -62,7 +62,6 @@ public function testSendAllDead()
         $t2->expects($this->once())->method('send')->will($this->throwException(new TransportException()));
         $t = new RoundRobinTransport([$t1, $t2]);
         $p = new \ReflectionProperty($t, 'cursor');
-        $p->setAccessible(true);
         $p->setValue($t, 0);
 
         try {
diff --git a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/SmtpTransportTest.php
@@ -162,7 +162,6 @@ private function invokeAssertResponseCode(string $response, array $codes): void
     {
         $transport = new SmtpTransport($this->getMockForAbstractClass(AbstractStream::class));
         $m = new \ReflectionMethod($transport, 'assertResponseCode');
-        $m->setAccessible(true);
         $m->invoke($transport, $response, $codes);
     }
 
diff --git a/src/Symfony/Component/Mime/Tests/MessageConverterTest.php b/src/Symfony/Component/Mime/Tests/MessageConverterTest.php
@@ -78,7 +78,6 @@ private function assertConversion(Email $expected)
         }
 
         $r = new \ReflectionProperty($expected, 'cachedBody');
-        $r->setAccessible(true);
         $r->setValue($expected, null);
         $r->setValue($converted, null);
 
diff --git a/src/Symfony/Component/Notifier/Bridge/Chatwork/Tests/ChatworkMessageBodyBuilderTest.php b/src/Symfony/Component/Notifier/Bridge/Chatwork/Tests/ChatworkMessageBodyBuilderTest.php
@@ -21,7 +21,6 @@ public function testSetTo()
         $builder = new ChatworkMessageBodyBuilder();
         $builder->to(['abc', 'def']);
         $property = new \ReflectionProperty($builder, 'to');
-        $property->setAccessible(true);
         $this->assertSame(['abc', 'def'], $property->getValue($builder));
         $builder->to('ghi');
         $this->assertSame(['ghi'], $property->getValue($builder));
@@ -32,7 +31,6 @@ public function testSetSelfUnread()
         $builder = new ChatworkMessageBodyBuilder();
         $builder->selfUnread(true);
         $property = new \ReflectionProperty($builder, 'selfUnread');
-        $property->setAccessible(true);
         $this->assertTrue($property->getValue($builder));
     }
 
@@ -41,7 +39,6 @@ public function testSetBody()
         $builder = new ChatworkMessageBodyBuilder();
         $builder->body('test body');
         $property = new \ReflectionProperty($builder, 'body');
-        $property->setAccessible(true);
         $this->assertEquals('test body', $property->getValue($builder));
     }
 
diff --git a/src/Symfony/Component/Scheduler/Tests/Trigger/PeriodicalTriggerTest.php b/src/Symfony/Component/Scheduler/Tests/Trigger/PeriodicalTriggerTest.php
@@ -30,7 +30,6 @@ public function testConstructor(PeriodicalTrigger $trigger, bool $optimizable =
         if ($optimizable) {
             // test that we are using the fast algorithm for short period of time
             $p = new \ReflectionProperty($trigger, 'intervalInSeconds');
-            $p->setAccessible(true);
             $this->assertNotSame(0, $p->getValue($trigger));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -589,7 +589,6 @@ private function hasNormalizationClosures(NodeInterface $node): bool`
`589`	`589`	`} catch (\ReflectionException) {`
`590`	`590`	`return false;`
`591`	`591`	`}`
`592`		`- $r->setAccessible(true);`
`593`	`592`
`594`	`593`	`return [] !== $r->getValue($node);`
`595`	`594`	`}`
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,6 @@ private function invokeAssertResponseCode(string $response, array $codes): void`
`162`	`162`	`{`
`163`	`163`	`$transport = new SmtpTransport($this->getMockForAbstractClass(AbstractStream::class));`
`164`	`164`	`$m = new \ReflectionMethod($transport, 'assertResponseCode');`
`165`		`- $m->setAccessible(true);`
`166`	`165`	`$m->invoke($transport, $response, $codes);`
`167`	`166`	`}`
`168`	`167`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ private function assertConversion(Email $expected)`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`$r = new \ReflectionProperty($expected, 'cachedBody');`
`81`		`- $r->setAccessible(true);`
`82`	`81`	`$r->setValue($expected, null);`
`83`	`82`	`$r->setValue($converted, null);`
`84`	`83`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ public function testConstructor(PeriodicalTrigger $trigger, bool $optimizable =`
`30`	`30`	`if ($optimizable) {`
`31`	`31`	`// test that we are using the fast algorithm for short period of time`
`32`	`32`	`$p = new \ReflectionProperty($trigger, 'intervalInSeconds');`
`33`		`- $p->setAccessible(true);`
`34`	`33`	`$this->assertNotSame(0, $p->getValue($trigger));`
`35`	`34`	`}`
`36`	`35`	`}`