minor symfony#51126 [Serializer] Fix tests for extended Context attributes (derrabus)

nicolas-grekas · nicolas-grekas · commit deb160abf523 · 2023-07-27T13:39:24.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Serializer] Fix tests for extended Context attributes | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Follows symfony#50983 | License | MIT | Doc PR | not needed In symfony#50983, I broke one test scenario where we test that extending the `Context` class works. This PR corrects that mistake. Commits ------- 2a6e93e [Serializer] Fix tests for extended Context attributes
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ContextMetadataTestTrait.php b/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ContextMetadataTestTrait.php
@@ -121,12 +121,12 @@ class ContextChildMetadataDummy
      * @var \DateTime
      */
     #[Groups(['extended', 'simple'])]
-    #[Context([DateTimeNormalizer::FORMAT_KEY => \DateTimeInterface::RFC3339])]
-    #[Context(
+    #[DummyContextChild([DateTimeNormalizer::FORMAT_KEY => \DateTimeInterface::RFC3339])]
+    #[DummyContextChild(
         normalizationContext: [DateTimeNormalizer::FORMAT_KEY => \DateTimeInterface::RFC3339_EXTENDED],
         groups: ['extended'],
     )]
-    #[Context(
+    #[DummyContextChild(
         denormalizationContext: [DateTimeNormalizer::FORMAT_KEY => 'd/m/Y'],
         groups: ['simple'],
     )]
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/Features/DummyContextChild.php b/src/Symfony/Component/Serializer/Tests/Normalizer/Features/DummyContextChild.php
@@ -13,14 +13,7 @@
 
 use Symfony\Component\Serializer\Annotation\Context;
 
-/**
- * Annotation class for @DummyContextChild().
- *
- * @Annotation
- * @NamedArgumentConstructor
- * @Target({"PROPERTY", "METHOD"})
- */
-#[\Attribute(\Attribute::TARGET_METHOD | \Attribute::TARGET_PROPERTY)]
+#[\Attribute(\Attribute::TARGET_METHOD | \Attribute::TARGET_PROPERTY | \Attribute::IS_REPEATABLE)]
 class DummyContextChild extends Context
 {
 }

Original file line number	Diff line number	Diff line change
`@@ -13,14 +13,7 @@`
`13`	`13`
`14`	`14`	`use Symfony\Component\Serializer\Annotation\Context;`
`15`	`15`
`16`		`-/**`
`17`		`- * Annotation class for @DummyContextChild().`
`18`		`- *`
`19`		`- * @Annotation`
`20`		`- * @NamedArgumentConstructor`
`21`		`- * @Target({"PROPERTY", "METHOD"})`
`22`		`- */`
`23`		`-#[\Attribute(\Attribute::TARGET_METHOD \| \Attribute::TARGET_PROPERTY)]`
	`16`	`+#[\Attribute(\Attribute::TARGET_METHOD \| \Attribute::TARGET_PROPERTY \| \Attribute::IS_REPEATABLE)]`
`24`	`17`	`class DummyContextChild extends Context`
`25`	`18`	`{`
`26`	`19`	`}`