You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/en/docs/contributing.md
+5-13Lines changed: 5 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -255,7 +255,9 @@ Here are the steps to help with translations.
255
255
256
256
#### Tips and guidelines
257
257
258
-
* Check the currently <ahref="https://github.com/tiangolo/fastapi/pulls"class="external-link"target="_blank">existing pull requests</a> for your language and add reviews requesting changes or approving them.
258
+
* Check the currently <ahref="https://github.com/tiangolo/fastapi/pulls"class="external-link"target="_blank">existing pull requests</a> for your language. You can filter the PRs by the ones with the label for your language. For example, for Spanish, the label is <ahref="https://github.com/tiangolo/fastapi/pulls?q=is%3Aopen+sort%3Aupdated-desc+label%3Alang-es+label%3Aawaiting-review"class="external-link"target="_blank">`lang-es`</a>.
259
+
260
+
* Add reviews requesting changes or approving them. For the languages I don't speak, I'll wait for several others to review the translation before merging.
259
261
260
262
!!! tip
261
263
You can <ahref="https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request"class="external-link"target="_blank">add comments with change suggestions</a> to existing pull requests.
@@ -264,19 +266,9 @@ Here are the steps to help with translations.
264
266
265
267
* Check if there's a <ahref="https://github.com/tiangolo/fastapi/discussions/categories/translations"class="external-link"target="_blank">GitHub Discussion</a> to coordinate translations for your language. You can subscribe to it, and when there's a new pull request to review, an automatic comment will be added to the discussion.
266
268
267
-
* Add a single pull request per page translated. That will make it much easier for others to review it.
268
-
269
-
For the languages I don't speak, I'll wait for several others to review the translation before merging.
270
-
271
-
* You can also check if there are translations for your language and add a review to them, that will help me know that the translation is correct and I can merge it.
272
-
* You could check in the <ahref="https://github.com/tiangolo/fastapi/discussions/categories/translations"class="external-link"target="_blank">GitHub Discussions</a> for your language.
273
-
* Or you can filter the existing PRs by the ones with the label for your language, for example, for Spanish, the label is <ahref="https://github.com/tiangolo/fastapi/pulls?q=is%3Aopen+sort%3Aupdated-desc+label%3Alang-es+label%3Aawaiting-review"class="external-link"target="_blank">`lang-es`</a>.
274
-
275
-
* Use the same Python examples and only translate the text in the docs. You don't have to change anything for this to work.
276
-
277
-
* Use the same images, file names, and links. You don't have to change anything for it to work.
269
+
* If you translate a page, add a single pull request per page translated. That will make it much easier for others to review it.
278
270
279
-
* To check the 2-letter code for the language you want to translate you can use the table <ahref="https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes"class="external-link"target="_blank">List of ISO 639-1 codes</a>.
271
+
* To check the 2-letter code for the language you want to translate, you can use the table <ahref="https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes"class="external-link"target="_blank">List of ISO 639-1 codes</a>.
0 commit comments