Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit eec9faf

Browse files
tiangolotiangolo
authored
Merge branch 'master' into Add-Chinese-Translation-for-docs-external-links.md
2 parents e101b86 + 47524ee commit eec9faf

1,417 files changed

Lines changed: 116477 additions & 27194 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.flake8‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/question.yml renamed to .github/DISCUSSION_TEMPLATE/questions.yml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
name: Question or Problem
2-
description: Ask a question or ask about a problem
31
labels: [question]
42
body:
53
- type: markdown
@@ -8,37 +6,37 @@ body:
86
Thanks for your interest in FastAPI! 🚀
97
108
Please follow these instructions, fill every question, and do every step. 🙏
11-
12-
I'm asking this because answering questions and solving problems in GitHub issues is what consumes most of the time.
13-
14-
I end up not being able to add new features, fix bugs, review pull requests, etc. as fast as I wish because I have to spend too much time handling issues.
9+
10+
I'm asking this because answering questions and solving problems in GitHub is what consumes most of the time.
11+
12+
I end up not being able to add new features, fix bugs, review pull requests, etc. as fast as I wish because I have to spend too much time handling questions.
1513
1614
All that, on top of all the incredible help provided by a bunch of community members, the [FastAPI Experts](https://fastapi.tiangolo.com/fastapi-people/#experts), that give a lot of their time to come here and help others.
1715
1816
That's a lot of work they are doing, but if more FastAPI users came to help others like them just a little bit more, it would be much less effort for them (and you and me 😅).
1917
2018
By asking questions in a structured way (following this) it will be much easier to help you.
21-
19+
2220
And there's a high chance that you will find the solution along the way and you won't even have to submit it and wait for an answer. 😎
2321
24-
As there are too many issues with questions, I'll have to close the incomplete ones. That will allow me (and others) to focus on helping people like you that follow the whole process and help us help you. 🤓
22+
As there are too many questions, I'll have to discard and close the incomplete ones. That will allow me (and others) to focus on helping people like you that follow the whole process and help us help you. 🤓
2523
- type: checkboxes
2624
id: checks
2725
attributes:
2826
label: First Check
2927
description: Please confirm and check all the following options.
3028
options:
31-
- label: I added a very descriptive title to this issue.
29+
- label: I added a very descriptive title here.
3230
required: true
33-
- label: I used the GitHub search to find a similar issue and didn't find it.
31+
- label: I used the GitHub search to find a similar question and didn't find it.
3432
required: true
3533
- label: I searched the FastAPI documentation, with the integrated search.
3634
required: true
3735
- label: I already searched in Google "How to X in FastAPI" and didn't find any information.
3836
required: true
3937
- label: I already read and followed all the tutorial in the docs and didn't find an answer.
4038
required: true
41-
- label: I already checked if it is not related to FastAPI but to [Pydantic](https://github.com/samuelcolvin/pydantic).
39+
- label: I already checked if it is not related to FastAPI but to [Pydantic](https://github.com/pydantic/pydantic).
4240
required: true
4341
- label: I already checked if it is not related to FastAPI but to [Swagger UI](https://github.com/swagger-api/swagger-ui).
4442
required: true
@@ -50,10 +48,10 @@ body:
5048
label: Commit to Help
5149
description: |
5250
After submitting this, I commit to one of:
53-
54-
* Read open issues with questions until I find 2 issues where I can help someone and add a comment to help there.
51+
52+
* Read open questions until I find 2 where I can help someone and add a comment to help there.
5553
* I already hit the "watch" button in this repository to receive notifications and I commit to help at least 2 people that ask questions in the future.
56-
* Implement a Pull Request for a confirmed bug.
54+
* Review one Pull Request by downloading the code and following [all the review process](https://fastapi.tiangolo.com/help-fastapi/#review-pull-requests).
5755
5856
options:
5957
- label: I commit to help with one of those options 👆

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,15 @@ blank_issues_enabled: false
22
contact_links:
33
- name: Security Contact
44
about: Please report security vulnerabilities to [email protected]
5+
- name: Question or Problem
6+
about: Ask a question or ask about a problem in GitHub Discussions.
7+
url: https://github.com/tiangolo/fastapi/discussions/categories/questions
8+
- name: Feature Request
9+
about: To suggest an idea or ask about a feature, please start with a question saying what you would like to achieve. There might be a way to do it already.
10+
url: https://github.com/tiangolo/fastapi/discussions/categories/questions
11+
- name: Show and tell
12+
about: Show what you built with FastAPI or to be used with FastAPI.
13+
url: https://github.com/tiangolo/fastapi/discussions/categories/show-and-tell
14+
- name: Translations
15+
about: Coordinate translations in GitHub Discussions.
16+
url: https://github.com/tiangolo/fastapi/discussions/categories/translations

‎.github/ISSUE_TEMPLATE/feature-request.yml‎

Lines changed: 0 additions & 181 deletions
This file was deleted.

‎.github/ISSUE_TEMPLATE/privileged.yml‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
name: Privileged
2+
description: You are @tiangolo or he asked you directly to create an issue here. If not, check the other options. 👇
3+
body:
4+
- type: markdown
5+
attributes:
6+
value: |
7+
Thanks for your interest in FastAPI! 🚀
8+
9+
If you are not @tiangolo or he didn't ask you directly to create an issue here, please start the conversation in a [Question in GitHub Discussions](https://github.com/tiangolo/fastapi/discussions/categories/questions) instead.
10+
- type: checkboxes
11+
id: privileged
12+
attributes:
13+
label: Privileged issue
14+
description: Confirm that you are allowed to create an issue here.
15+
options:
16+
- label: I'm @tiangolo or he asked me directly to create an issue here.
17+
required: true
18+
- type: textarea
19+
id: content
20+
attributes:
21+
label: Issue Content
22+
description: Add the content of the issue here.

‎.github/actions/comment-docs-preview-in-pr/app/main.py‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import logging
22
import sys
33
from pathlib import Path
4-
from typing import Optional
4+
from typing import Union
55

66
import httpx
77
from github import Github
@@ -14,7 +14,7 @@
1414
class Settings(BaseSettings):
1515
github_repository: str
1616
github_event_path: Path
17-
github_event_name: Optional[str] = None
17+
github_event_name: Union[str, None] = None
1818
input_token: SecretStr
1919
input_deploy_url: str
2020

@@ -42,15 +42,13 @@ class PartialGithubEvent(BaseModel):
4242
except ValidationError as e:
4343
logging.error(f"Error parsing event file: {e.errors()}")
4444
sys.exit(0)
45-
use_pr: Optional[PullRequest] = None
45+
use_pr: Union[PullRequest, None] = None
4646
for pr in repo.get_pulls():
4747
if pr.head.sha == event.workflow_run.head_commit.id:
4848
use_pr = pr
4949
break
5050
if not use_pr:
51-
logging.error(
52-
f"No PR found for hash: {event.workflow_run.head_commit.id}"
53-
)
51+
logging.error(f"No PR found for hash: {event.workflow_run.head_commit.id}")
5452
sys.exit(0)
5553
github_headers = {
5654
"Authorization": f"token {settings.input_token.get_secret_value()}"

0 commit comments

Comments
 (0)