fix flip button (#307)

clewis7 · web-flow · commit 0f5655ce9fa2 · 2023-09-21T12:45:14.000-04:00
* fix flip, update simple notebook

* change flip icon to arrow in direction of y-axis

* change tooltip
diff --git a/examples/notebooks/simple.ipynb b/examples/notebooks/simple.ipynb
@@ -108,7 +108,7 @@
    "source": [
     "**Use the handle on the bottom right corner of the _canvas_ to resize it. You can also pan and zoom using your mouse!**\n",
     "\n",
-    "By default the origin is on the bottom left, you can click the flip button to flip the y-axis, or use `plot.camera.world.scale_y *= -1`"
+    "By default the origin is on the bottom left, you can click the flip button to flip the y-axis, or use `plot.camera.local.scale_y *= -1`"
    ]
   },
   {
@@ -120,7 +120,7 @@
    },
    "outputs": [],
    "source": [
-    "plot.camera.world.scale_y *= -1"
+    "plot.camera.local.scale_y *= -1"
    ]
   },
   {
@@ -464,7 +464,7 @@
    },
    "outputs": [],
    "source": [
-    "plot_rgb.camera.world.scale_y *= -1"
+    "plot_rgb.camera.local.scale_y *= -1"
    ]
   },
   {
diff --git a/fastplotlib/layouts/_gridplot.py b/fastplotlib/layouts/_gridplot.py
@@ -415,9 +415,9 @@ def __init__(self, plot: GridPlot):
         self.flip_camera_button = Button(
             value=False,
             disabled=False,
-            icon="arrows-v",
+            icon="arrow-up",
             layout=Layout(width="auto"),
-            tooltip="flip",
+            tooltip="y-axis direction",
         )
 
         self.record_button = ToggleButton(
@@ -490,7 +490,11 @@ def maintain_aspect(self, obj):
 
     def flip_camera(self, obj):
         current = self.current_subplot
-        current.camera.world.scale_y *= -1
+        current.camera.local.scale_y *= -1
+        if current.camera.local.scale_y == -1:
+            self.flip_camera_button.icon = "arrow-down"
+        else:
+            self.flip_camera_button.icon = "arrow-up"
 
     def update_current_subplot(self, ev):
         for subplot in self.plot:
diff --git a/fastplotlib/layouts/_plot.py b/fastplotlib/layouts/_plot.py
@@ -170,7 +170,7 @@ def __init__(self, plot: Plot):
         self.flip_camera_button = Button(
             value=False,
             disabled=False,
-            icon="arrows-v",
+            icon="arrow-up",
             layout=Layout(width="auto"),
             tooltip="flip",
         )
@@ -224,7 +224,11 @@ def maintain_aspect(self, obj):
         self.plot.camera.maintain_aspect = self.maintain_aspect_button.value
 
     def flip_camera(self, obj):
-        self.plot.camera.world.scale_y *= -1
+        self.plot.camera.local.scale_y *= -1
+        if self.plot.camera.local.scale_y == -1:
+            self.flip_camera_button.icon = "arrow-down"
+        else:
+            self.flip_camera_button.icon = "arrow-up"
 
     def add_polygon(self, obj):
         ps = PolygonSelector(edge_width=3, edge_color="magenta")

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@`
`108`	`108`	`"source": [`
`109`	`109`	`"Use the handle on the bottom right corner of the _canvas_ to resize it. You can also pan and zoom using your mouse!\n",`
`110`	`110`	`"\n",`
`111`		- "By default the origin is on the bottom left, you can click the flip button to flip the y-axis, or use `plot.camera.world.scale_y *= -1`"
	`111`	+ "By default the origin is on the bottom left, you can click the flip button to flip the y-axis, or use `plot.camera.local.scale_y *= -1`"
`112`	`112`	`]`
`113`	`113`	`},`
`114`	`114`	`{`
`@@ -120,7 +120,7 @@`
`120`	`120`	`},`
`121`	`121`	`"outputs": [],`
`122`	`122`	`"source": [`
`123`		`- "plot.camera.world.scale_y *= -1"`
	`123`	`+ "plot.camera.local.scale_y *= -1"`
`124`	`124`	`]`
`125`	`125`	`},`
`126`	`126`	`{`
`@@ -464,7 +464,7 @@`
`464`	`464`	`},`
`465`	`465`	`"outputs": [],`
`466`	`466`	`"source": [`
`467`		`- "plot_rgb.camera.world.scale_y *= -1"`
	`467`	`+ "plot_rgb.camera.local.scale_y *= -1"`
`468`	`468`	`]`
`469`	`469`	`},`
`470`	`470`	`{`