fix ImageWidget.reset_vmin_vmax() (#690)

kushalkolar · web-flow · commit 78fa6d90169c · 2025-01-16T12:06:06.000-05:00
* fix iw.reset_vmin_vmax()

* fix vmin, vmax setting of first frame in imagewidget

* update screenshots since vmin changes

* update nb iw screenshots
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-0-reset.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-0-reset.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8e3f53d21e99424f11a3a920346909dce42f2c344ae9b43af5965bc2302ae9ab
-size 117732
+oid sha256:9b122f0ba9bfff0b0868778f09744870238bf7b4945e57410b6aa36341eaaf4a
+size 116781
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-0.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-0.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8e3f53d21e99424f11a3a920346909dce42f2c344ae9b43af5965bc2302ae9ab
-size 117732
+oid sha256:9b122f0ba9bfff0b0868778f09744870238bf7b4945e57410b6aa36341eaaf4a
+size 116781
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-279.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-279.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:b59639c87a6d02aaf8a14e8d681d763a795c15b7aa8d2d0a90dba3a5732e4fe5
-size 140917
+oid sha256:fcc5092f35c881da4a9b9f3c216fb608b8dfc27a791b83e0d5184ef3973746cf
+size 139375
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-max-33.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-max-33.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:5f9f5e1953aae367cca8add259c86d82fd5225f4cf4279c6504b1ecd9d5a0bd1
-size 125867
+oid sha256:3fabd9d52ae2815ae883a4c8c8a8b1385c0824e0212347896a09eb3600c29430
+size 124238
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-mean-13.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-mean-13.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3633ce4d8995ebdb224df9fcd8ebdf22ad9ffa72e3ef80692f4f691895faf903
-size 110162
+oid sha256:86ad31cab3aefa24a1c4c0adc2033cbc9fa594e9cf8ab8e4a6ff0a3630bb7896
+size 109041
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-mean-33.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-mean-33.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8ba9762d2d3fb7ddaa1628e40588b28780ac3e0185ec97187eb1975016aa32f1
-size 102404
+oid sha256:3ebf4e875199c7e682dc15aa03a36ea9f111618853a94076064b055bf6ce788e
+size 101209
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-reset.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-50-window-reset.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f9374ebf448c1692c63c3ca1c28b0d16125bb5ae021d9a7cc8a1beee3c25a183
-size 124817
+oid sha256:d8dbf6b76818315e40d9d4cc97807c4276c27e7a9a09d2643f74adf701ef1cdc
+size 123136
diff --git a/examples/notebooks/screenshots/nb-image-widget-movie-single-50.png b/examples/notebooks/screenshots/nb-image-widget-movie-single-50.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f9374ebf448c1692c63c3ca1c28b0d16125bb5ae021d9a7cc8a1beee3c25a183
-size 124817
+oid sha256:d8dbf6b76818315e40d9d4cc97807c4276c27e7a9a09d2643f74adf701ef1cdc
+size 123136
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-frame-apply-gaussian.png b/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-frame-apply-gaussian.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ecba9807b765ea12ad1183dabc35c9b6a2ba45f95aa0126d772801c3a5aba6e1
-size 92089
+oid sha256:39adce1898e5b00ccf9d8792bd4e76f2da2591a8c3f6e201a5c2af1f814d37cb
+size 58692
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-frame-apply-reset.png b/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-frame-apply-reset.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:433190c3f56075ca3e9a5486e5986424d31fb7b6f6145225a15bfafd5e00fa83
-size 74779
+oid sha256:d50b960c66acc6672aaeb6a97f6a69aad14f9e54060c3702679d6a5bf2b70e78
+size 70582
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-max-window-13.png b/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-max-window-13.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:de11fd007bad064ccb6574ee682d7cd25c64738768d1dc9e42b53c88cb78c46c
-size 155123
+oid sha256:d244a8a91d04380f2ebe255b2b56b3be5249c0a382821877710cae6bdaa2d414
+size 128643
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-mean-window-13.png b/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-mean-window-13.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ec9e3a90abd029a5fb6e149ba721f3340e499c26a2dd4aab6ab07a185bbc4ff0
-size 103878
+oid sha256:24c991457b8b081ee271cbdb03821ea1024c8340db92340e0e445bf3c70aba40
+size 97903
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-mean-window-5.png b/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50-mean-window-5.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f1c9b64c4c67a024a5dc839ad13f68ee60f3b3675144976c7e3b6ce989e0c822
-size 97746
+oid sha256:bdd62a9bd1ca4f1ff110a30fb4064d778f02120295a3e3d30552e06892146e40
+size 93658
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50.png b/examples/notebooks/screenshots/nb-image-widget-zfish-frame-50.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:51865c6bfd62d9691c638d4bc3b62507a61e873851dc35bad66acb0d41e4fe3e
-size 83536
+oid sha256:db7e2cf15ff3ce61b169b114c630e2339c1c6b5c687c580e1ee6964785df6790
+size 74844
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-frame-99.png b/examples/notebooks/screenshots/nb-image-widget-zfish-frame-99.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9f46a0e116fed8d474217d5a6ca6f9861647707e1abe049e796c67a417e197cd
-size 72243
+oid sha256:64d2d3fd91ac8e10736add5a82a312927ae6f976119cfa2aaa1fc1e008bcf6f1
+size 66038
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-frame-apply-gaussian.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-frame-apply-gaussian.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ac0fcaae315baf29a46f2c4151b988535934927441c13eef711b8567951b50cb
-size 106873
+oid sha256:8d2a805c85e1cdf5bd2d995600b033019680ac645d7634efeaf1db7d0d00d4aa
+size 79403
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-frame-apply-reset.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-frame-apply-reset.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a001606a953ea6b8a5c7f741532df4a006e7bf4dd31ff9e7b4f9f1025987153c
-size 109591
+oid sha256:440623bb4588994c4f52f17e027af29d1f2d5d330c5691630fd2acb9e38f8a25
+size 99033
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-max-window-13.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-max-window-13.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:cb99c2827dea7e49d5ffcd4fe10e4052671548500f05001067077a8841d03cc8
-size 168987
+oid sha256:9ee56adf8f2a516ef74a799e9e503f980c36c4dfb41f9ff6d8168cfcf65ad092
+size 132745
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-mean-window-13.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-mean-window-13.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:729b31d419eccf02eb617a10bb29b2f9295726f8167329ac0f7498e752688bb8
-size 113715
+oid sha256:de4733b82c2e77baa659582401eff0c70ec583c50462b33bcbfd2bb00ceaa517
+size 102959
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-mean-window-5.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50-mean-window-5.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7de21cfe1a21c1ef59bfb7121b2ef6f55dd9931d5885a3ee3c932dcf82389191
-size 116752
+oid sha256:6107f108b5a86ba376c53f5e207841c01a85b686100efb46e5df3565127201d2
+size 106765
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-50.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ca70505035a6b8cb8589a8219edd3d79eecdc93642e3d7f7db00516d27bac959
-size 122542
+oid sha256:caa15f6bc21a3be0f480b442414ec4b96b21cc1de2cdcb891b366692962d4ef8
+size 100753
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-99.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-frame-99.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a41f79b543ea852345ca5c5c3e401d39c43b9f5d4172805c48d7010d3e85e88a
-size 118378
+oid sha256:4e23288d695a5a91188b285f6a0a2c9f0643dd19f3d6dedb56f4389f44ed1f44
+size 98621
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-grid-init-mean-window-5.png b/examples/notebooks/screenshots/nb-image-widget-zfish-grid-init-mean-window-5.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:d364f4c18516c282cd284c731122618bdf3418b6d536afa7b0556105f89c3607
-size 119048
+oid sha256:8b4e1bb60466d7553b4d1afc14015b7c4edc6e79c724c0afb5acd123a10093d0
+size 105541
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-init-mean-window-5.png b/examples/notebooks/screenshots/nb-image-widget-zfish-init-mean-window-5.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:07bcc6ef243d9d3ffd7fae69facf655e7c02b1cb53ea96a38b40ed672655bf66
-size 86607
+oid sha256:3aad82db14f8100f669d2ad36b5bc3973b7c12457adfdd73adbc81c759338f7b
+size 80964
diff --git a/examples/notebooks/screenshots/nb-image-widget-zfish-mixed-rgb-cockatoo-frame-50.png b/examples/notebooks/screenshots/nb-image-widget-zfish-mixed-rgb-cockatoo-frame-50.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7270870881ac478f48a269b060c5bf7ca59e7abe8a42254162a0295f6165230b
-size 117870
+oid sha256:e40559eea03790315718c55b4ec4976aacb97a2f07bcdc49d917c044745687c2
+size 117144
diff --git a/examples/screenshots/image_widget_single_video.png b/examples/screenshots/image_widget_single_video.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:11ffeceb298c5b5d429da822e1764c11d862bf85630ce3390475c766366bceab
-size 91299
+oid sha256:de1750c9c1c3cd28c356fb51687f4a8f00afb3cc7e365502342168fce8459d3a
+size 90307
diff --git a/examples/screenshots/image_widget_videos.png b/examples/screenshots/image_widget_videos.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:2c17df678e54e9cddbd42869cfe7a32069b7ffa70e6227c95c333537e1efede6
-size 170218
+oid sha256:23d993e0b5b6bcfe67da7aa4ceab3f06e99358b00f287b9703c4c3bff19648ba
+size 169541
diff --git a/fastplotlib/widgets/image_widget/_widget.py b/fastplotlib/widgets/image_widget/_widget.py
@@ -1,13 +1,14 @@
+from copy import deepcopy
 from typing import Callable
 from warnings import warn
 
 import numpy as np
 
 from rendercanvas import BaseRenderCanvas
 
-from ... import Figure
+from ...layouts import ImguiFigure as Figure
 from ...graphics import ImageGraphic
-from ...utils import calculate_figure_shape
+from ...utils import calculate_figure_shape, quick_min_max
 from ...tools import HistogramLUTTool
 from ._sliders import ImageWidgetSliders
 
@@ -507,6 +508,12 @@ def __init__(
 
         graphic_kwargs.update({"cmap": cmap})
 
+        vmin_specified, vmax_specified = None, None
+        if "vmin" in graphic_kwargs.keys():
+            vmin_specified = graphic_kwargs.pop("vmin")
+        if "vmax" in graphic_kwargs.keys():
+            vmax_specified = graphic_kwargs.pop("vmax")
+
         self._figure: Figure = Figure(**figure_kwargs_default)
 
         self._histogram_widget = histogram_widget
@@ -518,7 +525,34 @@ def __init__(
 
             frame = self._process_indices(d, slice_indices=self._current_index)
             frame = self._process_frame_apply(frame, data_ix)
-            ig = ImageGraphic(frame, name="image_widget_managed", **graphic_kwargs)
+
+            if (vmin_specified is None) or (vmax_specified is None):
+                # if either vmin or vmax are not specified, calculate an estimate by subsampling
+                vmin_estimate, vmax_estimate = quick_min_max(d)
+
+                # decide vmin, vmax passed to ImageGraphic constructor based on whether it's user specified or now
+                if vmin_specified is None:
+                    # user hasn't specified vmin, use estimated value
+                    vmin = vmin_estimate
+                else:
+                    # user has provided a specific value, use that
+                    vmin = vmin_specified
+
+                if vmax_specified is None:
+                    vmax = vmax_estimate
+                else:
+                    vmax = vmax_specified
+            else:
+                # both vmin and vmax are specified
+                vmin, vmax = vmin_specified, vmax_specified
+
+            ig = ImageGraphic(
+                frame,
+                name="image_widget_managed",
+                vmin=vmin,
+                vmax=vmax,
+                **graphic_kwargs,
+            )
             subplot.add_graphic(ig)
             subplot.name = name
             subplot.set_title(name)
@@ -811,10 +845,6 @@ def reset_vmin_vmax(self):
             hlut = subplot.docks["right"]["histogram_lut"]
             hlut.set_data(data, reset_vmin_vmax=True)
 
-        else:
-            for ig in self.managed_graphics:
-                ig.reset_vmin_vmax()
-
     def reset_vmin_vmax_frame(self):
         """
         Resets the vmin vmax and HistogramLUT widgets w.r.t. the current data shown in the
