we can just subclass ImageGraphic

kushalkolar · kushalkolar · commit ce9c1973d03d · 2025-04-12T02:25:51.000-04:00
diff --git a/fastplotlib/graphics/image_volume.py b/fastplotlib/graphics/image_volume.py
@@ -4,6 +4,7 @@
 
 from ..utils import quick_min_max
 from ._base import Graphic
+from .image import ImageGraphic
 from .features import (
     TextureArray,
     ImageCmap,
@@ -71,7 +72,7 @@ def chunk_index(self) -> tuple[int, int, int]:
         return self._chunk_index
 
 
-class ImageVolumeGraphic(Graphic):
+class ImageVolumeGraphic(ImageGraphic):
     _features = {
         "data": TextureArray,
         "cmap": ImageCmap,
@@ -162,15 +163,6 @@ def __init__(
 
         self._set_world_object(world_object)
 
-    @property
-    def data(self) -> TextureArray:
-        """Get or set the image data"""
-        return self._data
-
-    @data.setter
-    def data(self, data):
-        self._data[:] = data
-
     @property
     def cmap(self) -> str:
         """colormap name"""
@@ -179,53 +171,3 @@ def cmap(self) -> str:
     @cmap.setter
     def cmap(self, name: str):
         self._cmap.set_value(self, name)
-
-    @property
-    def vmin(self) -> float:
-        """lower contrast limit"""
-        return self._vmin.value
-
-    @vmin.setter
-    def vmin(self, value: float):
-        self._vmin.set_value(self, value)
-
-    @property
-    def vmax(self) -> float:
-        """upper contrast limit"""
-        return self._vmax.value
-
-    @vmax.setter
-    def vmax(self, value: float):
-        self._vmax.set_value(self, value)
-
-    @property
-    def interpolation(self) -> str:
-        """image data interpolation method"""
-        return self._interpolation.value
-
-    @interpolation.setter
-    def interpolation(self, value: str):
-        self._interpolation.set_value(self, value)
-
-    @property
-    def cmap_interpolation(self) -> str:
-        """cmap interpolation method"""
-        return self._cmap_interpolation.value
-
-    @cmap_interpolation.setter
-    def cmap_interpolation(self, value: str):
-        self._cmap_interpolation.set_value(self, value)
-
-    def reset_vmin_vmax(self):
-        """
-        Reset the vmin, vmax by estimating it from the data
-
-        Returns
-        -------
-        None
-
-        """
-
-        vmin, vmax = quick_min_max(self._data.value)
-        self.vmin = vmin
-        self.vmax = vmax
