fix: Delete data sources from registry when using the diffing logic (#2669)

achals · web-flow · commit fc00ca8fc091 · 2022-05-11T15:01:33.000-07:00
Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/sdk/python/feast/diff/registry_diff.py b/sdk/python/feast/diff/registry_diff.py
@@ -295,6 +295,11 @@ def apply_diff_to_registry(
                 registry.delete_feature_view(
                     feature_view_obj.name, project, commit=False,
                 )
+            elif feast_object_diff.feast_object_type == FeastObjectType.DATA_SOURCE:
+                ds_obj = cast(DataSource, feast_object_diff.current_feast_object)
+                registry.delete_data_source(
+                    ds_obj.name, project, commit=False,
+                )
 
         if feast_object_diff.transition_type in [
             TransitionType.CREATE,
diff --git a/sdk/python/feast/infra/offline_stores/file.py b/sdk/python/feast/infra/offline_stores/file.py
@@ -187,7 +187,6 @@ def evaluate_historical_retrieval():
                 entity_df_event_timestamp_col
             )
 
-            join_keys = []
             all_join_keys = []
 
             # Load feature view data from sources and join them incrementally

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,6 @@ def evaluate_historical_retrieval():`
`187`	`187`	`entity_df_event_timestamp_col`
`188`	`188`	`)`
`189`	`189`
`190`		`- join_keys = []`
`191`	`190`	`all_join_keys = []`
`192`	`191`
`193`	`192`	`# Load feature view data from sources and join them incrementally`