Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vonagam
Copy link
Member

@vonagam vonagam commented Sep 12, 2019

If provided a logger should have info property, which is used here.

Instead of void | null, just void for return type of logging functions.

msg is not a string, but any since it is used to log errors (as shown in link above) and they might not be a string.

error property is required now, if you don't want to log stuff, just do not provide logger since it is optional already.

@daffl daffl merged commit 3e1d26c into feathersjs:master Sep 16, 2019
@vonagam vonagam deleted the fix-express-error-handler-type branch September 16, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants