Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixing issue with docker image on demo apps not getting updated #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blrchen merged 10 commits into from
Sep 20, 2022
Merged

Fixing issue with docker image on demo apps not getting updated #686

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
89c9bfd
Adding DevSkim linter to Github actions
jainr Sep 9, 2022
1c8c13d
Merge pull request #1 from jainr/rijai/devskim
jainr Sep 9, 2022
a9c2343
Fix in ARM template to pull latest tagged release image from dockerhub
jainr Sep 14, 2022
cd056a9
Removing dev skim file from this branch
jainr Sep 14, 2022
cf52bd8
Merge branch 'main' into rijai/dockerimageversion
jainr Sep 14, 2022
d7a41da
Fixing linkedin org reference
jainr Sep 14, 2022
ef949a1
Fixing merge conflicts
jainr Sep 14, 2022
dc9ecbd
Removing the docker index url from dockerhub image name as it seems t…
jainr Sep 20, 2022
5e763b5
Merge branch 'main' of https://github.com/feathr-ai/feathr into rijai…
jainr Sep 20, 2022
cb32fb4
Adding to the right file, had a dockerhub workflow file with differen…
jainr Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,21 @@ jobs:
with:
app-name: 'feathr-sql-registry'
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE_FEATHR_SQL_REGISTRY }}
images: 'index.docker.io/feathrfeaturestore/feathr-registry:nightly'
images: 'feathrfeaturestore/feathr-registry:nightly'

- name: Deploy to Feathr Purview Registry Azure Web App
id: deploy-to-purview-webapp
uses: azure/webapps-deploy@v2
with:
app-name: 'feathr-purview-registry'
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE_FEATHR_PURVIEW_REGISTRY }}
images: 'index.docker.io/feathrfeaturestore/feathr-registry:nightly'
images: 'feathrfeaturestore/feathr-registry:nightly'

- name: Deploy to Feathr RBAC Registry Azure Web App
id: deploy-to-rbac-webapp
uses: azure/webapps-deploy@v2
with:
app-name: 'feathr-rbac-registry'
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE_FEATHR_RBAC_REGISTRY }}
images: 'index.docker.io/feathrfeaturestore/feathr-registry:nightly'
images: 'feathrfeaturestore/feathr-registry:nightly'