chore: bump deps and change node engine #276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HassanBahati
commented
Jul 9, 2025
| @@ -54,15 +54,15 @@ | |||
| "prettier": "^1.19.1", | |||
| "sinon": "^7.5.0", | |||
| "tslint": "^5.20.0", | |||
| "typescript": "^4.2.5" | |||
| "typescript": "^5.8.3" | |||
There was a problem hiding this comment.
bumping typescript to latest major version because the errors below pop up when it is left current version in the project, the errors below come up;
MacBook-Pro firebase-functions-test % npm test
> [email protected] pretest
> node_modules/.bin/tsc
node_modules/@google-cloud/storage/build/cjs/src/crc32c.d.ts:6:39 - error TS2315: Type 'Int32Array' is not generic.
6 declare const CRC32C_EXTENSION_TABLE: Int32Array<ArrayBuffer>;
~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@google-cloud/storage/build/cjs/src/crc32c.d.ts:115:45 - error TS2315: Type 'Int32Array' is not generic.
115 static readonly CRC32C_EXTENSION_TABLE: Int32Array<ArrayBuffer>;
~~~~~~~~~~~~~~~~~~~~~~~
Found 2 errors in the same file, starting at: node_modules/@google-cloud/storage/build/cjs/src/crc32c.d.ts:6on digging a bit into this, typescript version 4.5 seems to have introduced improvements to built-in type definitions for TypedArray types (like Int32Array, Uint8Array, etc.) and Int32Array was made an error, by defining Int32Array more strictly
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies and restricts the supported Node.js engine versions.
- Bump lodash and its type definitions to patch versions
- Upgrade TypeScript to 5.8.3
- Change the Node.js engine field to only allow LTS lines (20.x, 22.x, 24.x)
Comments suppressed due to low confidence (2)
package.json:41
- Please include the corresponding lockfile updates (package-lock.json or yarn.lock) in this PR to ensure the bumped dependencies are consistently tracked.
"@types/lodash": "^4.17.20",
package.json:65
- Make sure to update any CI or local test configurations to cover these new Node.js engine versions so tests continue to run against the intended LTS releases.
"node": "20.x || 22.x || 24.x"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
20.x || 22.x || 24.xCode sample
N/A