Update initializeApp snippets #180
Conversation
Change-Id: I8a06e42fea1ed960ca47c006987760ec8d09b5a5
andirayo
left a comment
There was a problem hiding this comment.
Thanks for doing this.
However, I would recommend setting a "full set" of Firebase options in order to signal to developers that they should always set the full set of values and not select for the task at hand.
(because it might break them later on when they add another Firebase service or a Firebase service changes its requirements)
| // setDatabaseURL(...) | ||
| // setStorageBucket(...) |
There was a problem hiding this comment.
I would recommend setting these too, to make it clear to developers that they should just always set the full set of values and not select for the task at hand.
Also I recommend to use example values (as it was done before).
There was a problem hiding this comment.
It's likely that Firebase moves to a place where not all of these resources are created on project creation.
I don't think we should do any more silent breaking changes in the future. If we want to require DatabaseURL tomorrow we should break FirebaseApp.
There was a problem hiding this comment.
(changed back to example values)
Change-Id: I6760974a5d1b9b2aa2f084a31a04a049f6128137
No description provided.