refactor(admob): delete unused snippets #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@rosariopfernandes I think you're right, these are unused. Thanks for catching this! |
Contributor
|
Oops this is my bad but two of these snippets are actually used: I'll have to restore those ... no need for you to do anything though I might just hardcode them into the docs since it's basically one line. |
Member
Author
|
@samtstern The link you posted takes me to this section:
If you're talking about the Other that this one, I don't see any other Java/Kotlin snippet in that docs page you linked. |
thatfiredev
commented
Apr 15, 2021
Comment on lines
9
to
15
| // [START ads_on_create] | ||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| // ... | ||
| MobileAds.initialize(this) | ||
| } | ||
| // [END ads_on_create] |
Contributor
|
Yep you're right, it was a false alarm! Something else broke the page and I assumed it was this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is failing in #285 due to AdMob Breaking Changes.
I was going to upgrade this code to the new admob v20.0.0, but then I noticed that most of it is not even shown on our docs. Maybe it's time to clean it up?