-
Notifications
You must be signed in to change notification settings - Fork 418
Add android snippets #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add android snippets #452
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d9add2
Add android snippets?
morganchen12 1a23fa3
fix build and bad snippets
morganchen12 7db4dec
Merge branch 'master' into mc/cache
morganchen12 f2b4604
add size comments
morganchen12 c0fa970
Update firestore/app/src/main/java/com/google/example/firestore/DocSn…
morganchen12 e8e2a19
Merge branch 'master' into mc/cache
morganchen12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,9 @@ | |
| import com.google.firebase.firestore.FirebaseFirestoreException; | ||
| import com.google.firebase.firestore.FirebaseFirestoreSettings; | ||
| import com.google.firebase.firestore.ListenerRegistration; | ||
| import com.google.firebase.firestore.MemoryCacheSettings; | ||
| import com.google.firebase.firestore.MetadataChanges; | ||
| import com.google.firebase.firestore.PersistentCacheSettings; | ||
| import com.google.firebase.firestore.Query; | ||
| import com.google.firebase.firestore.Query.Direction; | ||
| import com.google.firebase.firestore.QueryDocumentSnapshot; | ||
|
|
@@ -128,18 +130,28 @@ public void setup() { | |
| // [END get_firestore_instance] | ||
|
|
||
| // [START set_firestore_settings] | ||
| FirebaseFirestoreSettings settings = new FirebaseFirestoreSettings.Builder() | ||
| .setPersistenceEnabled(true) | ||
| .build(); | ||
| FirebaseFirestoreSettings settings = | ||
| new FirebaseFirestoreSettings.Builder(db.getFirestoreSettings()) | ||
| // Use memory-only cache | ||
| .setLocalCacheSettings(MemoryCacheSettings.newBuilder().build()) | ||
| // Use persistent disk cache (default) | ||
| .setLocalCacheSettings(PersistentCacheSettings.newBuilder() | ||
| .build()) | ||
| .build(); | ||
| db.setFirestoreSettings(settings); | ||
| // [END set_firestore_settings] | ||
| } | ||
|
|
||
| public void setupCacheSize() { | ||
| FirebaseFirestore db = FirebaseFirestore.getInstance(); | ||
| // [START fs_setup_cache] | ||
| FirebaseFirestoreSettings settings = new FirebaseFirestoreSettings.Builder() | ||
| .setCacheSizeBytes(FirebaseFirestoreSettings.CACHE_SIZE_UNLIMITED) | ||
| .build(); | ||
| FirebaseFirestoreSettings settings = | ||
| new FirebaseFirestoreSettings.Builder(db.getFirestoreSettings()) | ||
| .setLocalCacheSettings(PersistentCacheSettings.newBuilder() | ||
| // Set size to 1 MB | ||
| .setSizeBytes(1_000_000) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for the late comment. This needs to be fixed too: 1_000_000 is not 1MB. And we should use 100 MB here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in #456. |
||
| .build()) | ||
| .build(); | ||
| db.setFirestoreSettings(settings); | ||
| // [END fs_setup_cache] | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.