Fix typo in useremail #177
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
auth/email_action_links.js
Outdated
| // [START sign_in_with_email_link] | ||
| // Admin SDK API to generate the sign in with email link. | ||
| const usremail = '[email protected]'; | ||
| const useremail = '[email protected]'; |
There was a problem hiding this comment.
useremail already exists as a const above, so we'll have to use a new variable name.
There was a problem hiding this comment.
@samtstern Then I'd suggest to be consistent with the other examples and reduce it to a single const at the top of the file? Well, I see the documentation uses different snippets of this file, so that doesn't help either.
We could wrap the code snippets in a function to allow different scopes to declare the same const.
(I don't know if that would break the [START sign_in_with_email_link] parsing)
() => {
// [START sign_in_with_email_link]
// Admin SDK API to generate the sign in with email link.
const useremail = '[email protected]';
....
// [END sign_in_with_email_link]
}
https://firebase.google.cn/docs/auth/admin/email-action-links?hl=EN-GB
There was a problem hiding this comment.
@peili yes I think you're right that one function per snippet would be the better approach, just like we do over here:
https://github.com/firebase/snippets-web/blob/master/functions/callable.js#L17
|
@googlebot I signed it! |
thatfiredev
left a comment
There was a problem hiding this comment.
@peili I went ahead and wrapped the code inside a function so that we can get this merged.
Thank you for your contribution!
No description provided.