Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove RaisedButton and FlatButton diagrams #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2022
Merged

Remove RaisedButton and FlatButton diagrams #180

merged 2 commits into from
May 7, 2022

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 6, 2022 •
edited
Loading

Fixes flutter/flutter#103192

Source codes for RaisedButton and FlatButton are removed, diagram generator throws errors with these widgets.
flutter/flutter#98547
flutter/flutter#98545

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested a review from Piinks May 6, 2022 11:55
@TahaTesser
Copy link
Member Author

@yusuf-goog
Looks like the token has expired again, this was updated here

@yusuf-goog yusuf-goog mentioned this pull request May 6, 2022
Merged
8 tasks
Piinks
Piinks approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! LGTM once the CI issue is sorted. Thanks! :)

@yusuf-goog
Copy link
Contributor

Fix coming in #181

@TahaTesser TahaTesser force-pushed the remove_raised_and_flat_button branch from f4bd1c4 to 8f8071a Compare May 7, 2022 07:38
@TahaTesser TahaTesser merged commit babac4a into flutter:master May 7, 2022
@TahaTesser TahaTesser deleted the remove_raised_and_flat_button branch May 7, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove RaisedButton and FlatButton diagrams
3 participants
@TahaTesser @yusuf-goog @Piinks