-
Notifications
You must be signed in to change notification settings - Fork 376
Closed
Labels
P2important to work on, but not at the top of the work list.important to work on, but not at the top of the work list.testing
Description
We updated our DevTools benchmark test thresholds for wasm recently (see #9018).
This was due to due to https://issues.chromium.org/issues/396208308 (Flutter SDK change: flutter/flutter#163175)
However, the benchmark tests have begun failing again, not just for wasm but for dart2js. Example failures:
[JS Benchmarks] The following benchmark scores exceeded their expected thresholds:
[devtools_offlinePerformanceScreen.js] flutter_frame.total_time.p90 was 25900 μs, which exceeded the expected threshold, 16666.6 μs.
[WASM Benchmarks] The following benchmark scores exceeded their expected thresholds:
[devtools_offlineCpuProfilerScreen.wasm] flutter_frame.total_time.average was 51450.781190019195 μs, which exceeded the expected threshold, 33333.2 μs.
[devtools_offlineCpuProfilerScreen.wasm] flutter_frame.total_time.p50 was 50416.0 μs, which exceeded the expected threshold, 33333.3 μs.
[devtools_offlineCpuProfilerScreen.wasm] flutter_frame.build_time.p90 was 19060.0 μs, which exceeded the expected threshold, 16666.6 μs.
[devtools_offlineCpuProfilerScreen.wasm] flutter_frame.raster_time.average was 36769.819219790676 μs, which exceeded the expected threshold, 33333.2 μs.
[devtools_offlineCpuProfilerScreen.wasm] flutter_frame.raster_time.p50 was 34560.0 μs, which exceeded the expected threshold, 33333.3 μs.
[devtools_offlineCpuProfilerScreen.wasm] flutter_frame.raster_time.p90 was 73665.0 μs, which exceeded the expected threshold, 66666.6 μs.
Example run: https://github.com/flutter/devtools/actions/runs/13934373079/job/38999046750
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2important to work on, but not at the top of the work list.important to work on, but not at the top of the work list.testing