Fix unsupported devices not showing "Enable x" if there are no other devices #9428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…devices In the list of devices we include devices that are not supported/enabled for the current platform, allowing you to enable them. However, the logic here would skip the entire device table if there are no enabled/supported devices, which would cause nothing to show up if there are none already enabled. This changes the logic so the table is always shown if there are either kind of device, and only shows the help text if none are enabled. Fixes Dart-Code/Dart-Code#5661
DanTup
commented
Sep 8, 2025
|
autosubmit label was removed for flutter/devtools/9428, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
|
autosubmit label was removed for flutter/devtools/9428, because - The status or check suite Verify PR Release Note Requirements has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the list of devices we include devices that are not supported/enabled for the current platform, allowing you to enable them. However, the logic here would skip the entire device table if there are no enabled/supported devices, which would cause nothing to show up if there are none already enabled.
This changes the logic so the table is always shown if there are either kind of device, and only shows the help text if none are enabled.
Fixes Dart-Code/Dart-Code#5661
Before:
After: