tests to verify the default is to apply the hack

LongCatIsLooong · LongCatIsLooong · commit aedc37a3e007 · 2023-07-13T11:11:04.000-07:00
diff --git a/lib/ui/text.dart b/lib/ui/text.dart
@@ -3024,7 +3024,7 @@ abstract class ParagraphBuilder {
     return const bool.hasEnvironment('SKPARAGRAPH_REMOVE_ROUNDING_HACK')
         || _roundingHackDisabledInDebugMode;
   }
-  static bool _roundingHackDisabledInDebugMode = true;
+  static bool _roundingHackDisabledInDebugMode = false;
 
   /// Only works in debug mode. Do not call this method as it is for migration
   /// purposes only and will soon be removed.
diff --git a/lib/web_ui/lib/text.dart b/lib/web_ui/lib/text.dart
@@ -690,7 +690,7 @@ abstract class ParagraphBuilder {
     return const bool.hasEnvironment('SKPARAGRAPH_REMOVE_ROUNDING_HACK')
         || _roundingHackDisabledInDebugMode;
   }
-  static bool _roundingHackDisabledInDebugMode = true;
+  static bool _roundingHackDisabledInDebugMode = false;
   static void setDisableRoundingHack(bool disableRoundingHack) {
     assert(() {
       _roundingHackDisabledInDebugMode = disableRoundingHack;
diff --git a/lib/web_ui/test/canvaskit/text_test.dart b/lib/web_ui/test/canvaskit/text_test.dart
@@ -146,6 +146,19 @@ void testMain() {
       }
       ui.ParagraphBuilder.setDisableRoundingHack(roundingHackWasDisabled);
     });
+
+    test('rounding hack applied by default', () {
+      const double fontSize = 1.25;
+      const String text = '12345';
+      assert((fontSize * text.length).truncate() != fontSize * text.length);
+      expect(ui.ParagraphBuilder.shouldDisableRoundingHack, isFalse);
+      final ui.ParagraphBuilder builder = ui.ParagraphBuilder(ui.ParagraphStyle(fontSize: fontSize));
+      builder.addText(text);
+      final ui.Paragraph paragraph = builder.build()
+        ..layout(const ui.ParagraphConstraints(width: text.length * fontSize));
+      expect(paragraph.maxIntrinsicWidth, greaterThan(text.length * fontSize));
+    });
+
     // TODO(hterkelsen): https://github.com/flutter/flutter/issues/71520
   }, skip: isSafari || isFirefox);
 }
diff --git a/testing/dart/paragraph_test.dart b/testing/dart/paragraph_test.dart
@@ -254,4 +254,16 @@ void main() {
     }
     ParagraphBuilder.setDisableRoundingHack(roundingHackWasDisabled);
   });
+
+  test('rounding hack applied by default', () {
+    const double fontSize = 1.25;
+    const String text = '12345';
+    assert((fontSize * text.length).truncate() != fontSize * text.length);
+    expect(ParagraphBuilder.shouldDisableRoundingHack, isFalse);
+    final ParagraphBuilder builder = ParagraphBuilder(ParagraphStyle(fontSize: fontSize));
+    builder.addText(text);
+    final Paragraph paragraph = builder.build()
+      ..layout(const ParagraphConstraints(width: text.length * fontSize));
+    expect(paragraph.maxIntrinsicWidth, greaterThan(text.length * fontSize));
+  });
 }

Original file line number	Diff line number	Diff line change
`@@ -3024,7 +3024,7 @@ abstract class ParagraphBuilder {`
`3024`	`3024`	`return const bool.hasEnvironment('SKPARAGRAPH_REMOVE_ROUNDING_HACK')`
`3025`	`3025`	`\|\| _roundingHackDisabledInDebugMode;`
`3026`	`3026`	`}`
`3027`		`- static bool _roundingHackDisabledInDebugMode = true;`
	`3027`	`+ static bool _roundingHackDisabledInDebugMode = false;`
`3028`	`3028`
`3029`	`3029`	`/// Only works in debug mode. Do not call this method as it is for migration`
`3030`	`3030`	`/// purposes only and will soon be removed.`
Original file line number	Diff line number	Diff line change
`@@ -690,7 +690,7 @@ abstract class ParagraphBuilder {`
`690`	`690`	`return const bool.hasEnvironment('SKPARAGRAPH_REMOVE_ROUNDING_HACK')`
`691`	`691`	`\|\| _roundingHackDisabledInDebugMode;`
`692`	`692`	`}`
`693`		`- static bool _roundingHackDisabledInDebugMode = true;`
	`693`	`+ static bool _roundingHackDisabledInDebugMode = false;`
`694`	`694`	`static void setDisableRoundingHack(bool disableRoundingHack) {`
`695`	`695`	`assert(() {`
`696`	`696`	`_roundingHackDisabledInDebugMode = disableRoundingHack;`