Apply suggestions from code review

koji-1009 · mdebbar · web-flow · commit 5e8a06153f85 · 2025-03-21T17:10:44.000+09:00
Co-authored-by: Mouad Debbar &lt;mouad.debbar@gmail.com&gt;
diff --git a/engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart b/engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart
@@ -961,19 +961,17 @@ class EditingState {
   /// See also:
   ///
   ///  * [applyTextToDomElement], which is used for non-focused elements.
-  void applyToDomElement(DomHTMLElement? domElement, {bool isComposing = false}) {
+  void applyToDomElement(DomHTMLElement? domElement, {bool updateSelection = true}) {
     if (domInstanceOfString(domElement, 'HTMLInputElement')) {
       final DomHTMLInputElement element = domElement! as DomHTMLInputElement;
       element.value = text;
-      if (!isComposing) {
-        // If the user is composing, we should not update the selection range.
+      if (updateSelection) {
         element.setSelectionRange(minOffset, maxOffset);
       }
     } else if (domInstanceOfString(domElement, 'HTMLTextAreaElement')) {
       final DomHTMLTextAreaElement element = domElement! as DomHTMLTextAreaElement;
       element.value = text;
-      if (!isComposing) {
-        // If the user is composing, we should not update the selection range.
+      if (updateSelection) {
         element.setSelectionRange(minOffset, maxOffset);
       }
     } else {
@@ -1152,7 +1150,7 @@ class GloballyPositionedTextEditingStrategy extends DefaultTextEditingStrategy {
       // Set the last editing state if it exists, this is critical for a
       // users ongoing work to continue uninterrupted when there is an update to
       // the transform.
-      lastEditingState?.applyToDomElement(domElement, isComposing: isComposing);
+      lastEditingState?.applyToDomElement(domElement, updateSelection: !isComposing);
       // On Chrome, when a form is focused, it opens an autofill menu
       // immediately.
       // Flutter framework sends `setEditableSizeAndTransform` for informing
@@ -1203,7 +1201,7 @@ class SafariDesktopTextEditingStrategy extends DefaultTextEditingStrategy {
       // the transform.
       // If domElement is not focused cursor location will not be correct.
       moveFocusToActiveDomElement();
-      lastEditingState?.applyToDomElement(activeDomElement, isComposing: isComposing);
+      lastEditingState?.applyToDomElement(activeDomElement, updateSelection: !isComposing);
     }
   }
 
@@ -1451,7 +1449,7 @@ abstract class DefaultTextEditingStrategy
     if (!isEnabled || !editingState!.isValid) {
       return;
     }
-    lastEditingState!.applyToDomElement(domElement, isComposing: isComposing);
+    lastEditingState!.applyToDomElement(domElement, updateSelection: !isComposing);
   }
 
   void placeElement() {
@@ -1900,7 +1898,7 @@ class FirefoxTextEditingStrategy extends GloballyPositionedTextEditingStrategy {
     // Set the last editing state if it exists, this is critical for a
     // users ongoing work to continue uninterrupted when there is an update to
     // the transform.
-    lastEditingState?.applyToDomElement(activeDomElement, isComposing: isComposing);
+    lastEditingState?.applyToDomElement(activeDomElement, updateSelection: !isComposing);
   }
 }
 
