Move analysis test to shard tests. (#139161)

godofredoc · web-flow · commit 8b6277e63868 · 2023-11-28T23:58:55.000Z
This is part of the effort to deprecated adhoc tests. Bug: #139153
diff --git a/.ci.yaml b/.ci.yaml
@@ -242,13 +242,12 @@ platform_properties:
 
 targets:
   - name: Linux analyze
-    recipe: flutter/flutter
+    recipe: flutter/flutter_drone
     timeout: 60
     properties:
+      shard: analyze
       tags: >
-        ["framework","hostonly","linux"]
-      validation: analyze
-      validation_name: Analyze
+        ["framework","hostonly","shard","linux"]
 
   - name: Linux analyzer_benchmark
     recipe: devicelab/devicelab_drone
@@ -2948,14 +2947,13 @@ targets:
   - name: Staging_build_linux analyze
     presubmit: false
     bringup: true
-    recipe: flutter/flutter
+    recipe: flutter/flutter_drone
     timeout: 60
     properties:
+      shard: analyze
       ignore_flakiness: "true"
       tags: >
-        ["framework","hostonly","linux"]
-      validation: analyze
-      validation_name: Analyze
+        ["framework","hostonly","shard","linux"]
 
   - name: Mac_benchmark animated_complex_opacity_perf_macos__e2e_summary
     presubmit: false
diff --git a/TESTOWNERS b/TESTOWNERS
@@ -295,8 +295,6 @@
 /dev/devicelab/bin/tasks/windows_startup_test.dart @loic-sharma @flutter/desktop
 
 ## Host only framework tests
-# Linux analyze
-/dev/bots/analyze.dart @HansMuller @flutter/framework
 # Linux docs
 # Linux docs_test
 # Linux docs_publish
@@ -321,6 +319,7 @@
 # TODO(keyonghan): add files/paths for below framework host only testss.
 # https://github.com/flutter/flutter/issues/82068
 #
+# analyze @HansMuller @flutter/framework
 # build_tests @eliasyishak @flutter/tool
 # ci_yaml flutter roller @caseyhillers @flutter/infra
 # coverage @godofredoc @flutter/infra
diff --git a/dev/bots/test.dart b/dev/bots/test.dart
@@ -264,6 +264,7 @@ Future<void> main(List<String> args) async {
       'skp_generator': _runSkpGeneratorTests,
       'realm_checker': _runRealmCheckerTest,
       'customer_testing': _runCustomerTesting,
+      'analyze': _runAnalyze,
       kTestHarnessShardName: _runTestHarnessTests, // Used for testing this script; also run as part of SHARD=framework_tests, SUBSHARD=misc.
     });
   } catch (error, stackTrace) {
@@ -1588,6 +1589,19 @@ Future<void> _runCustomerTesting() async {
   );
 }
 
+// Runs analysis tests.
+Future<void> _runAnalyze() async {
+  printProgress('${green}Running analysis testing$reset');
+  await runCommand(
+    'dart',
+    <String>[
+      '--enable-asserts',
+      path.join(flutterRoot, 'dev', 'bots', 'analyze.dart'),
+    ],
+    workingDirectory: flutterRoot,
+  );
+}
+
 /// Runs the skp_generator from the flutter/tests repo.
 ///
 /// See also the customer_tests shard.
