Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit e27a19e

Browse files
goderbauergoderbauer
authored
Remove outdated ignores (#108924)
1 parent b972f87 commit e27a19e

File tree

12 files changed

+16
-27
lines changed

12 files changed

+16
-27
lines changed

‎dev/integration_tests/deferred_components_test/lib/main.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ class MyHomePageState extends State<MyHomePage> {
6262
// the placeholder text.
6363
Future<void>.delayed(const Duration(milliseconds: 750), () {
6464
setState(() {
65-
// See https://github.com/dart-lang/sdk/issues/46894
66-
// ignore: prefer_const_constructors
6765
postLoadDisplayWidget = component1.LogoScreen();
6866
});
6967
});

‎dev/integration_tests/web/lib/stack_trace.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,8 @@ class StackFrameEquality implements Equality<StackFrame> {
150150
e1.method == e2.method;
151151
}
152152

153-
// TODO(dnfield): This ignore shouldn't be necessary, see https://github.com/dart-lang/sdk/issues/46477
154153
@override
155-
int hash(StackFrame e) { // ignore: avoid_renaming_method_parameters
154+
int hash(StackFrame e) {
156155
return Object.hash(e.number, e.packageScheme, e.package, e.packagePath, e.line, e.column, e.className, e.method);
157156
}
158157

‎dev/integration_tests/web_e2e_tests/test_driver/text_editing_integration.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,11 @@ void main() {
234234

235235
KeyboardEvent dispatchKeyboardEvent(
236236
EventTarget target, String type, Map<String, dynamic> args) {
237-
// ignore: implicit_dynamic_function
238237
final Object jsKeyboardEvent = js_util.getProperty(window, 'KeyboardEvent') as Object;
239238
final List<dynamic> eventArgs = <dynamic>[
240239
type,
241240
args,
242241
];
243-
244-
// ignore: implicit_dynamic_function
245242
final KeyboardEvent event = js_util.callConstructor(
246243
jsKeyboardEvent, js_util.jsify(eventArgs) as List<dynamic>)
247244
as KeyboardEvent;

‎packages/flutter_test/lib/src/binding.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
325325
}
326326

327327
@override
328-
// ignore: MUST_CALL_SUPER
328+
// ignore: must_call_super
329329
void initLicenses() {
330330
// Do not include any licenses, because we're a test, and the LICENSE file
331331
// doesn't get generated for tests.

‎packages/flutter_test/lib/src/event_simulation.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ String? _keyLabel(LogicalKeyboardKey key) {
3636
return null;
3737
}
3838

39-
// ignore: avoid_classes_with_only_static_members
4039
/// A class that serves as a namespace for a bunch of keyboard-key generation
4140
/// utilities.
4241
class KeyEventSimulator {

‎packages/flutter_tools/lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ class FlutterVersion {
100100

101101
String? _repositoryUrl;
102102
String? get repositoryUrl {
103-
final String _ = channel; // ignore: no_leading_underscores_for_local_identifiers
103+
final String _ = channel;
104104
return _repositoryUrl;
105105
}
106106

‎packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ void main() {
547547
'-w', '1',
548548
'testhostname',
549549
],
550-
postBuildCommand: null, // ignore: avoid_redundant_argument_values
550+
postBuildCommand: null,
551551
installCommand: const <String>[
552552
'scp',
553553
'-r',
@@ -637,7 +637,7 @@ void main() {
637637
'-w', '1',
638638
'192.168.178.1',
639639
],
640-
postBuildCommand: null, // ignore: avoid_redundant_argument_values
640+
postBuildCommand: null,
641641
installCommand: const <String>[
642642
'scp',
643643
'-r',
@@ -727,7 +727,7 @@ void main() {
727727
'-w', '1',
728728
'::1',
729729
],
730-
postBuildCommand: null, // ignore: avoid_redundant_argument_values
730+
postBuildCommand: null,
731731
installCommand: const <String>[
732732
'scp',
733733
'-r',
@@ -821,7 +821,7 @@ void main() {
821821
'-w', '1',
822822
'testhostname',
823823
],
824-
postBuildCommand: null, // ignore: avoid_redundant_argument_values
824+
postBuildCommand: null,
825825
installCommand: <String>[
826826
'scp',
827827
'-r',
@@ -901,7 +901,7 @@ void main() {
901901
'-w', '1',
902902
'testhostname',
903903
],
904-
postBuildCommand: null, // ignore: avoid_redundant_argument_values
904+
postBuildCommand: null,
905905
installCommand: const <String>[
906906
'scp',
907907
'-r',
@@ -1226,7 +1226,7 @@ void main() {
12261226
'testhostname',
12271227
],
12281228
pingSuccessRegex: RegExp(r'[<=]\d+ms'),
1229-
postBuildCommand: null, // ignore: avoid_redundant_argument_values
1229+
postBuildCommand: null,
12301230
installCommand: const <String>[
12311231
'scp',
12321232
'-r',

‎packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,6 @@ void main() {
251251

252252
// Unfortunately Device, despite not being immutable, has an `operator ==`.
253253
// Until we fix that, we have to also ignore related lints here.
254-
// ignore: avoid_implementing_value_types
255254
class ThrowingScreenshotDevice extends ScreenshotDevice {
256255
@override
257256
Future<LaunchResult> startApp(

‎packages/flutter_tools/test/general.shard/android/android_workflow_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ void main() {
3838
testWithoutContext('AndroidWorkflow handles a null AndroidSDK', () {
3939
final AndroidWorkflow androidWorkflow = AndroidWorkflow(
4040
featureFlags: TestFeatureFlags(),
41-
androidSdk: null, // ignore: avoid_redundant_argument_values
41+
androidSdk: null,
4242
operatingSystemUtils: FakeOperatingSystemUtils(),
4343
);
4444

@@ -391,7 +391,7 @@ Review licenses that have not been accepted (y/N)?
391391
);
392392

393393
final AndroidValidator androidValidator = AndroidValidator(
394-
androidStudio: null, // ignore: avoid_redundant_argument_values
394+
androidStudio: null,
395395
androidSdk: sdk,
396396
fileSystem: fileSystem,
397397
logger: logger,
@@ -439,7 +439,7 @@ Review licenses that have not been accepted (y/N)?
439439
..directory = fileSystem.directory('/foo/bar');
440440

441441
final AndroidValidator androidValidator = AndroidValidator(
442-
androidStudio: null, // ignore: avoid_redundant_argument_values
442+
androidStudio: null,
443443
androidSdk: sdk,
444444
fileSystem: fileSystem,
445445
logger: logger,
@@ -488,7 +488,7 @@ Review licenses that have not been accepted (y/N)?
488488

489489
final ValidationResult validationResult = await AndroidValidator(
490490
androidSdk: sdk,
491-
androidStudio: null, // ignore: avoid_redundant_argument_values
491+
androidStudio: null,
492492
fileSystem: fileSystem,
493493
logger: logger,
494494
platform: FakePlatform()..environment = <String, String>{'HOME': '/home/me', 'JAVA_HOME': 'home/java'},
@@ -510,8 +510,8 @@ Review licenses that have not been accepted (y/N)?
510510

511511
testWithoutContext('Mentions `flutter config --android-sdk if user has no AndroidSdk`', () async {
512512
final ValidationResult validationResult = await AndroidValidator(
513-
androidSdk: null, // ignore: avoid_redundant_argument_values
514-
androidStudio: null, // ignore: avoid_redundant_argument_values
513+
androidSdk: null,
514+
androidStudio: null,
515515
fileSystem: fileSystem,
516516
logger: logger,
517517
platform: FakePlatform()..environment = <String, String>{'HOME': '/home/me', 'JAVA_HOME': 'home/java'},

‎packages/flutter_tools/test/general.shard/base/logger_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,6 @@ void main() {
566566
outputStdout().join('\n'),
567567
'$message' // initial message
568568
'${" " * 4}${" " * 8}' // margin (4) and space for the time at the end (8)
569-
// ignore: missing_whitespace_between_adjacent_strings
570569
'$a' // first tick
571570
'$blankLine' // clearing the line
572571
'Rude Interrupting Cow\n' // message

‎packages/flutter_tools/test/general.shard/device_port_forwarder_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import 'dart:io' as io; // ignore: dart_io_import
5+
import 'dart:io' as io;
66
import 'package:flutter_tools/src/base/io.dart';
77
import 'package:flutter_tools/src/device_port_forwarder.dart';
88
import 'package:test/fake.dart';

‎packages/flutter_tools/test/general.shard/web/devfs_web_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
// @dart = 2.8
66

7-
// ignore_for_file: avoid_redundant_argument_values
8-
97
import 'dart:io' hide Directory, File;
108

119
import 'package:flutter_tools/src/artifacts.dart';

0 commit comments

Comments
 (0)