fix noop toString() diagnostics (#108836)

pq · web-flow · commit fd0da75cc92e · 2022-08-02T21:51:06.000Z
diff --git a/packages/flutter_tools/lib/src/migrate/migrate_manifest.dart b/packages/flutter_tools/lib/src/migrate/migrate_manifest.dart
@@ -171,7 +171,7 @@ class MigrateManifest {
       deletedFileManifestContents.write('  - $localPath\n');
     }
 
-    final String migrateManifestContents = 'merged_files:\n${mergedFileManifestContents.toString()}conflict_files:\n${conflictFilesManifestContents.toString()}added_files:\n${newFileManifestContents.toString()}deleted_files:\n${deletedFileManifestContents.toString()}';
+    final String migrateManifestContents = 'merged_files:\n${mergedFileManifestContents}conflict_files:\n${conflictFilesManifestContents}added_files:\n${newFileManifestContents}deleted_files:\n$deletedFileManifestContents';
     final File migrateManifest = getManifestFileFromDirectory(migrateRootDir);
     migrateManifest.createSync(recursive: true);
     migrateManifest.writeAsStringSync(migrateManifestContents, flush: true);
diff --git a/packages/flutter_tools/test/integration.shard/build_ios_config_only_test.dart b/packages/flutter_tools/test/integration.shard/build_ios_config_only_test.dart
@@ -40,7 +40,7 @@ void main() {
     printOnFailure('Output of flutter build ios:');
     final String firstRunStdout = firstRunResult.stdout.toString();
     printOnFailure('First run stdout: $firstRunStdout');
-    printOnFailure('First run stderr: ${firstRunResult.stderr.toString()}');
+    printOnFailure('First run stderr: ${firstRunResult.stderr}');
 
     expect(firstRunResult.exitCode, 0);
     expect(firstRunStdout, contains('Running pod install'));
@@ -72,7 +72,7 @@ void main() {
     final ProcessResult secondRunResult = await processManager.run(buildCommand, workingDirectory: workingDirectory);
     final String secondRunStdout = secondRunResult.stdout.toString();
     printOnFailure('Second run stdout: $secondRunStdout');
-    printOnFailure('Second run stderr: ${secondRunResult.stderr.toString()}');
+    printOnFailure('Second run stderr: ${secondRunResult.stderr}');
 
     expect(secondRunResult.exitCode, 0);
     // Do not run "pod install" when nothing changes.

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ class MigrateManifest {`
`171`	`171`	`deletedFileManifestContents.write(' - $localPath\n');`
`172`	`172`	`}`
`173`	`173`
`174`		`- final String migrateManifestContents = 'merged_files:\n${mergedFileManifestContents.toString()}conflict_files:\n${conflictFilesManifestContents.toString()}added_files:\n${newFileManifestContents.toString()}deleted_files:\n${deletedFileManifestContents.toString()}';`
	`174`	`+ final String migrateManifestContents = 'merged_files:\n${mergedFileManifestContents}conflict_files:\n${conflictFilesManifestContents}added_files:\n${newFileManifestContents}deleted_files:\n$deletedFileManifestContents';`
`175`	`175`	`final File migrateManifest = getManifestFileFromDirectory(migrateRootDir);`
`176`	`176`	`migrateManifest.createSync(recursive: true);`
`177`	`177`	`migrateManifest.writeAsStringSync(migrateManifestContents, flush: true);`