Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[google_sign_in_web] Move js-interop layer out of generated #101855

New issue
New issue
Closed
Closed
[google_sign_in_web] Move js-interop layer out of generated#101855
Assignees
peixinli
Labels
P3Issues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.good first issueRelatively approachable for first-time contributorsp: google_sign_inThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.platform-webWeb applications specifically
@ditman

Description

@ditman
ditman
opened on Apr 13, 2022

The js-interop layer of the web version of Google Sign In used to be generated by the js_facade_gen script, but it is no longer.

Proposal

Move the js-interop layer (gapi.dart, gapiauth2.dart...) outside of generated (or rename generated to js_interop or similar), so the files don't receive any special treatment.

Also: fix tests, and whatever issues the analyzer may start having with the change, of course.

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.good first issueRelatively approachable for first-time contributorsp: google_sign_inThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.platform-webWeb applications specifically

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions