Description
This is inspired by #105182
I will use the exact plugins in this incident to describe the issue, but the issue can happen on any plugin in the repo.
This is the sequence of the events that caused a breakage.
- A commit landed and updated video_player version. The commit passed post commit CI.
- The new version of video_player is released.
- A new commit is landed on master/main, it is not related to video_player or image_picker. (So presubmit didn't run any image_picker tests)
- Image_picker's example app depends on video_player, and the example app contains some tests. Because video_player's new version is released, image_picker runs the tests with the new video_player version the first time on CI, and the new version of video_player broke the image_picker test, which caused the ci to fail.
The breakage was around dependencies in androidx test libraries. I have very limited knowledge on this topic so I'm not sure how severe the damage could be. My guess is that any flutter app that has the same set up as image_picker_example would break if they depend on video_player.
The bigger issue is that we don't know if the video_player breaks other flutter apps out there, it was nice that we had image_picker_example depends on video_player, which caught the issue. It would be even better to have this failure show up before we publish the video_player, so that we can catch that and fixing the issue before landing/releasing video_player.