Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create top level consts for service extension names so that they can be referenced in other tools #106502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kenzieschmoll opened this issue Jun 23, 2022 · 1 comment
Assignees
Labels
a: devtools DevTools related - suite of performance and debugging tools

Comments

@kenzieschmoll
Copy link
Member

In the framework, we have several service extensions that are registered throughout the different bindings (example 'performanceOverlay' https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/widgets/binding.dart#L374).

These strings can easily be pulled out into constants so that they can be accessed by other libraries. DevTools stores a copy of each of these strings right now so that we can call the service extensions. This is not very robust because a name change or deletion could break our tooling. We should define the extension names as constants in the framework so that we can reference these names from Flutter in DevTools for more robustness and less copied code.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: devtools DevTools related - suite of performance and debugging tools
Projects
None yet
Development

No branches or pull requests

1 participant