Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Team members should be able to land reverts TBR #108374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zanderso opened this issue Jul 26, 2022 · 9 comments
Closed

Team members should be able to land reverts TBR #108374

zanderso opened this issue Jul 26, 2022 · 9 comments
Assignees
@ricardoamador
Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team

Comments

@zanderso
Copy link
Member

The autosubmit bot blocked a clean revert of the tip-of-tree commit here: #108349

@keyonghan @godofredoc
@zanderso zanderso added team-infra Owned by Infrastructure team P1 High-priority issues at the top of the work list labels Jul 26, 2022
@godofredoc
Copy link
Contributor

We need to revisit the logic to detect if a revert is a ToT revert

@keyonghan
Copy link
Contributor

Ah, the logic was removed when refactoring the validations: https://github.com/flutter/cocoon/pull/1891/files

@keyonghan keyonghan self-assigned this Jul 26, 2022
@keyonghan keyonghan mentioned this issue Jul 26, 2022
Closed
@keyonghan
Copy link
Contributor

Assigning to @ricardoamador for a more general revert support.

@keyonghan keyonghan assigned ricardoamador and unassigned keyonghan Jul 27, 2022
@zanderso
Copy link
Member Author

zanderso commented Aug 3, 2022

Another example here #108882

@ricardoamador ricardoamador mentioned this issue Aug 11, 2022
Closed
@zanderso
Copy link
Member Author

zanderso commented Aug 29, 2022 •
edited
Loading

flutter/cocoon#2062 Does not appear to be working. See #110479. Bumping this to P2 since the tree is closed on this issue every few days.

@zanderso zanderso added P2 and removed P1 High-priority issues at the top of the work list labels Aug 29, 2022
@keyonghan
Copy link
Contributor

@ricardoamador is this fixed?

@ricardoamador
Copy link
Contributor

Yes reverts can be landed. Unless this is somehow not working now?

@ricardoamador
Copy link
Contributor

I am closing this as fixed. The mentioned issue has been resolved as well.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
@flutter-triage-bot flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P2 labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ricardoamador ricardoamador

Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Land ToT revert immediately without waiting for validations keyonghan/cocoon
4 participants
@zanderso @ricardoamador @godofredoc @keyonghan