Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Regression in new_gen_gc_count #108972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iskakaushik opened this issue Aug 4, 2022 · 3 comments
Closed

Regression in new_gen_gc_count #108972

iskakaushik opened this issue Aug 4, 2022 · 3 comments
Labels
c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression

Comments

@iskakaushik
Copy link
Contributor

iskakaushik commented Aug 4, 2022 •
edited
Loading

Two benchmarks have regressed:

https://flutter-flutter-perf.skia.org/e/?begin=1659550807&end=1659571884&keys=Xaa17a7f0dd32cbfd584d52cc03a3586f&num_commits=50&request_type=1&xbaroffset=30278

image

https://flutter-flutter-perf.skia.org/e/?begin=1659560286&end=1659584048&keys=Xe635fff46bf2885624ca9a652a4b88ed&num_commits=50&request_type=1&xbaroffset=30283

image

The culprit here doesn't seem to be obvious.

They are pointing to 80679f0, but no other commits around that time seem suspicious.
@iskakaushik
Copy link
Contributor Author

Both of these are only seen in a moto g4 device, could it be that the device is in a bad state?

@iskakaushik iskakaushik added c: regression It was better in the past than it is now P0 Critical issues such as a build break or regression engine flutter/engine repository. See also e: labels. labels Aug 4, 2022
@iskakaushik
Copy link
Contributor Author

Given that this regresses just the count and #108868 could change timing of tests which new gen gc could be sensitive towards, I'm closing this issue.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iskakaushik