Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[proposal] Add fontFamilyFallback property into ThemeData #109773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pedromassango opened this issue Aug 18, 2022 · 2 comments · Fixed by #112976
Closed

[proposal] Add fontFamilyFallback property into ThemeData #109773

pedromassango opened this issue Aug 18, 2022 · 2 comments · Fixed by #112976
Assignees
@justinmc
Labels
a: text input Entering text in a text field or keyboard related problems a: typography Text rendering, possibly libtxt c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@pedromassango
Copy link
Member

Use case

Currently it is possible to set fontFamily globally in our theme using ThemeData, but we can't do it for fontFamilyFallback.

Proposal

Add fontFamilyFallback property into ThemeData.

ThemeData getAppTheme(Brightness brightness) {
  final colors = brightness == Brightness.light ? colorsLight : colorsDark;

  return ThemeData(
    brightness: brightness,
    fontFamily: AppFonts.roboto,
    fontFamilyFallback:               ----------------------> Needed property
    scaffoldBackgroundColor: colors.background,
    // ... more configurations.
  );
}
@maheshj01 maheshj01 added the in triage Presently being triaged by the triage team label Aug 18, 2022
@maheshj01 maheshj01 changed the title proposal: Add fontFamilyFallback property into ThemeData [proposal] Add fontFamilyFallback property into ThemeData Aug 18, 2022
@maheshj01 maheshj01 added c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Aug 18, 2022
@pedromassango pedromassango added the a: typography Text rendering, possibly libtxt label Aug 18, 2022
@HansMuller
Copy link
Contributor

This seems like a reasonable proposal.

@HansMuller HansMuller added the a: text input Entering text in a text field or keyboard related problems label Aug 18, 2022
@justinmc justinmc self-assigned this Aug 18, 2022
@justinmc justinmc mentioned this issue Oct 5, 2022
Merged
@rydmike rydmike mentioned this issue Oct 26, 2022
Open
42 tasks
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@justinmc justinmc

Labels
a: text input Entering text in a text field or keyboard related problems a: typography Text rendering, possibly libtxt c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fontFamilyFallback to ThemeData justinmc/flutter
4 participants
@justinmc @HansMuller @maheshj01 @pedromassango