Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Slider to support Material 3 #111451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #91605
darrenaustin opened this issue Sep 13, 2022 · 9 comments · Fixed by #114624
Closed
Tracked by #91605

Update Slider to support Material 3 #111451

darrenaustin opened this issue Sep 13, 2022 · 9 comments · Fixed by #114624
Assignees
@TahaTesser
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list r: fixed Issue is closed as already fixed in a newer version

Comments

@darrenaustin
Copy link
Contributor

As part of the Material 3 specification there are updates to slider's visuals:

unnamed-3

We should update the Slider widget to support this Material 3 look and tokens.
@darrenaustin darrenaustin added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 13, 2022
@darrenaustin darrenaustin moved this to 🗺 Planned in Material 3 Sep 13, 2022
@darrenaustin darrenaustin mentioned this issue Sep 13, 2022
Closed
70 tasks
@TahaTesser
Copy link
Member

TahaTesser commented Sep 13, 2022 •
edited
Loading

I would like to help with some of these Material 3 issues, can I take this or some other issue? )

@darrenaustin
Copy link
Contributor Author

@TahaTesser thanks for volunteering. This one may be a bit more involved as the slider is pretty complicated. If you have any issues let me or @Piinks know and we can try to help.

@TahaTesser
Copy link
Member

TahaTesser commented Sep 23, 2022 •
edited
Loading

Update:
Making progress on this

@TahaTesser
Copy link
Member

Update:
Need to do some fine tweaks and write tests.

@TahaTesser TahaTesser moved this to To do in Nevercode Sep 30, 2022
@TahaTesser TahaTesser moved this from To do to In progress in Nevercode Sep 30, 2022
@TahaTesser TahaTesser mentioned this issue Oct 4, 2022
Closed
@TahaTesser
Copy link
Member

This needs #112922 to be fixed.

This was referenced Oct 5, 2022
Merged
Open
This was referenced Oct 13, 2022
Closed
Open
Merged
@TahaTesser
Copy link
Member

#113367 fixes overlay issues on desktop for M3 support.

@Piinks Piinks added the P1 High-priority issues at the top of the work list label Oct 20, 2022
@Piinks Piinks moved this to In Progress in Slider Updates Oct 20, 2022
@TahaTesser TahaTesser moved this from 🗺 Planned to 🚧 In Progress in Material 3 Oct 21, 2022
@TahaTesser
Copy link
Member

TahaTesser commented Oct 25, 2022 •
edited
Loading

Update:
Writing tests. I found that there is no Slider default colors test. Existing test check for colors when using Slider theme.

Aiming to file a PR by tomorrow.

@TahaTesser TahaTesser mentioned this issue Oct 26, 2022
Merged
8 tasks
@TahaTesser
Copy link
Member

#114079 landed today.
Working on part 2, which will close this issue.
Aiming to file a PR by tomorrow.

@TahaTesser TahaTesser mentioned this issue Nov 3, 2022
Merged
8 tasks
Repository owner moved this from In Progress to Done in Slider Updates Nov 17, 2022
Repository owner moved this from 🚧 In Progress to ✅ Done in Material 3 Nov 17, 2022
Repository owner moved this from In progress to Done (PR merged) in Nevercode Nov 17, 2022
@TahaTesser TahaTesser added the r: fixed Issue is closed as already fixed in a newer version label Nov 18, 2022
@TahaTesser TahaTesser mentioned this issue Nov 18, 2022
Merged
8 tasks
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TahaTesser TahaTesser

Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list r: fixed Issue is closed as already fixed in a newer version
Projects
Nevercode
Status: Done (PR merged)
Slider Updates
Status: Done
Material 3
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Material 3 support for Slider - Part 2 NevercodeHQ/flutter
3 participants
@darrenaustin @Piinks @TahaTesser