Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move updateSemantics from PlatformDispatcher to FlutterView #112221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
goderbauer opened this issue Sep 22, 2022 · 5 comments · Fixed by flutter/engine#36673
Closed

Move updateSemantics from PlatformDispatcher to FlutterView #112221

goderbauer opened this issue Sep 22, 2022 · 5 comments · Fixed by flutter/engine#36673
Assignees
@a-wallen
Labels
a: multi window Issues related to multi window support c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project

Comments

@goderbauer
Copy link
Member

In a multi view world we will be creating separate semantics trees for each view. For this, the updateSemantics should move from the singleton PlatformDispatcher to the individual FlutterViews.

Once the framework has been moved over, the old updateSemantics on the PlatfromDispatcher can be removed.
@goderbauer goderbauer added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. a: multi window Issues related to multi window support labels Sep 22, 2022
@goderbauer goderbauer moved this to Ready in Multi Window Sep 22, 2022
@a-wallen a-wallen self-assigned this Sep 26, 2022
@chinmaygarde chinmaygarde added c: new feature Nothing broken; request for a new capability P3 Issues that are less important to the Flutter project labels Sep 26, 2022
@a-wallen
Copy link
Contributor

a-wallen commented Oct 6, 2022

@goderbauer what do you think the tests should look like for this?

@goderbauer
Copy link
Member Author

Do we have any tests covering PlatformDispatcher.updateSemantics? Those could be re-purposed, but with calling FlutterView.updateSemantics instead.

I think ultimately, you want a test to ensure that any information passed to FlutterView.updateSemantics is forwarded properly to the embedder API and invokes the expected callbacks there, e.g. https://github.com/flutter/engine/blob/966f249fb132df0f91d326c022adaa0f8d52dd77/shell/platform/embedder/embedder.h#L1740

This was referenced Oct 8, 2022
Merged
Merged
Merged
@a-wallen a-wallen moved this to In Progress in Flutter Desktop Oct 24, 2022
@a-wallen a-wallen moved this from Ready to In Progress in Multi Window Oct 24, 2022
Repository owner moved this from In Progress to Done in Multi Window Oct 28, 2022
Repository owner moved this from In Progress to Done in Flutter Desktop Oct 28, 2022
@a-wallen a-wallen reopened this Nov 7, 2022
@a-wallen
Copy link
Contributor

a-wallen commented Nov 7, 2022

Reopening as flutter/engine#37388 reverted the issue that closed this.

@a-wallen a-wallen mentioned this issue Nov 7, 2022
Closed
8 tasks
@a-wallen
Copy link
Contributor

Fixed forward by #114857. Can close now that change is landed.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@a-wallen a-wallen

Labels
a: multi window Issues related to multi window support c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project
Projects
Flutter Desktop
Status: Done
Multi Window
Status: Done
Milestone
No milestone
3 participants
@chinmaygarde @goderbauer @a-wallen