Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Windows framework_tests_misc is 5.21% flaky #113705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fluttergithubbot opened this issue Oct 19, 2022 · 3 comments · Fixed by #113784
Closed

Windows framework_tests_misc is 5.21% flaky #113705

fluttergithubbot opened this issue Oct 19, 2022 · 3 comments · Fixed by #113784
Assignees
@HansMuller @pdblasi-google
Labels
c: flake Tests that sometimes, but not always, incorrectly pass framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression

Comments

@fluttergithubbot
Copy link
Contributor

The post-submit test builder Windows framework_tests_misc had a flaky ratio 5.21% for the past (up to) 100 commits, which is above our 2.00% threshold.

One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_misc/7357
Commit: f9c1556

Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_misc/7357
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_misc/7340
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_misc/7336
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_misc/7332
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_misc/7322

Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Windows%20framework_tests_misc

Please follow https://github.com/flutter/flutter/wiki/Reducing-Test-Flakiness#fixing-flaky-tests to fix the flakiness and enable the test back after validating the fix (internal dashboard to validate: go/flutter_test_flakiness).
@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. P1 c: flake Tests that sometimes, but not always, incorrectly pass labels Oct 19, 2022
@jmagman
Copy link
Member

jmagman commented Oct 19, 2022

It's hovering right below the 30 minute timeout when passing, probably time to shard it out between two shards.

tracing tests taking 2 minutes

flutter/dev/bots/test.dart

Line 994 in 8fd46ce

await runTracingTests(); 

ELAPSED TIME: 2min 3.480s for ..\..\bin\flutter.bat build appbundle --profile lib\control.dart in dev\tracing_tests

fix tests are taking almost 8 minutes:

flutter/dev/bots/test.dart

Line 995 in 8fd46ce

await runFixTests(); 

ELAPSED TIME: 7min 46.241s for ..\..\..\bin\cache\dart-sdk\bin\dart.exe fix --compare-to-golden in packages\flutter\test_fixes

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8799850360215272241/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/test_stdout

@pdblasi-google
Copy link
Contributor

Yeah, I've been looking into this. This started with this engine roll which updated the dart sdk. Before this engine/dart-sdk roll, the fix tests were running at less than 2 mins, but after the roll, those tests are consistently over 6 mins.

I'm writing up a dart-lang/sdk issue now.

This was referenced Oct 19, 2022
Closed
Merged
@pdblasi-google pdblasi-google mentioned this issue Oct 21, 2022
Merged
8 tasks
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
@flutter-triage-bot flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P1 labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HansMuller HansMuller

@pdblasi-google pdblasi-google

Labels
c: flake Tests that sometimes, but not always, incorrectly pass framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression
Projects
None yet
Milestone
No milestone
4 participants
@jmagman @HansMuller @fluttergithubbot @pdblasi-google