Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[web] Support --no-prebuilt-dart-sdk in the web engine #113772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdebbar opened this issue Oct 20, 2022 · 4 comments
Closed

[web] Support --no-prebuilt-dart-sdk in the web engine #113772

mdebbar opened this issue Oct 20, 2022 · 4 comments
Labels
e: local-engine-development Local builds of the engine working better engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression platform-web Web applications specifically

Comments

@mdebbar
Copy link
Contributor

mdebbar commented Oct 20, 2022

Recently, the web engine build became reliant on prebuilt dart sdks (see flutter/engine#36336, flutter/engine#36851 and #113759).

That means we always use prebuilts and ignore the --no-prebuilt-dart-sdk flag.

This issue is about adding support for the --no-prebuilt-dart-sdk flag. If the flag is set, we build a dart sdk with the default host toolchain.

@mdebbar mdebbar added engine flutter/engine repository. See also e: labels. platform-web Web applications specifically P2 Important issues not at the top of the work list e: local-engine-development Local builds of the engine working better labels Oct 20, 2022
@dcharkes
Copy link
Contributor

This is making the Flutter Dart HHH bot red currently.

https://ci.chromium.org/p/dart/g/flutter-hhh/console


Generating GN files in: out/host_debug
ERROR at //flutter/web_sdk/BUILD.gn:257:34: Undefined identifier in string expansion.
      "file:///" + rebase_path("$host_prebuilt_dart_sdk/.."),
                                 ^---------------------
"host_prebuilt_dart_sdk" is not currently in scope.
See //flutter/web_sdk/BUILD.gn:277:1: whence it was called.
_compile_outline("flutter_dartdevc_kernel_sdk_outline") {
^--------------------------------------------------------
See //flutter/BUILD.gn:97:26: which caused the file to be included.
        public_deps += [ "//flutter/web_sdk" ]
                         ^------------------

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8799722016116422561/+/u/gn_--full-dart-sdk_--no-prebuilt-dart-sdk/stdout

Please consider reverting

until this is addressed.

cc @eyebrowsoffire

@dcharkes dcharkes added the P0 Critical issues such as a build break or regression label Oct 21, 2022
@jason-simmons
Copy link
Member

Landed flutter/engine#36926

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
@whesse
Copy link
Contributor

whesse commented Jan 30, 2023

This issue does not seem to have been resolved completely, as building the wasm_release target with the --no-prebuilt-dart-sdk flag does not work. The prebuilt_dart_sdk variable is unconditionally set to true in https://github.com/flutter/engine/pull/36851/files#diff-fed47f409f6a27a39fe7b0e6b3ebbceb645d295259e350614afeb8c0a3eecae2R636

Further work on making the wasm_release target build without a prebuilt Dart SDK is tracked in a new issue #119513 , and this issue can remain closed.

@Hixie Hixie removed the P2 Important issues not at the top of the work list label Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: local-engine-development Local builds of the engine working better engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression platform-web Web applications specifically
Projects
None yet
Development

No branches or pull requests

5 participants