Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clip fix regressed Impeller raster times on Android #114021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zanderso opened this issue Oct 25, 2022 · 6 comments
Closed

Clip fix regressed Impeller raster times on Android #114021

zanderso opened this issue Oct 25, 2022 · 6 comments
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list

Comments

@zanderso
Copy link
Member

The fix here #113770 regressed the raster times of the list_text_layout_impeller_perf__e2e_summary benchmark:

https://flutter-flutter-perf.skia.org/e/?begin=1666280999&end=1666307527&keys=X4dfec7919bc8bf5ff16c3a0b23e31e3d&num_commits=50&request_type=1&xbaroffset=31668

@jonahwilliams @dnfield @iskakaushik
@zanderso zanderso added c: performance Relates to speed or footprint issues (see "perf:" labels) e: impeller Impeller rendering backend issues and features requests labels Oct 25, 2022
@zanderso zanderso moved this to 🤔 Needs Triage in Impeller Oct 25, 2022
@zanderso
Copy link
Member Author

new_gallery_impeller__transition_perf also regressed.

@jonahwilliams
Copy link
Member

Is clipping on Android with impeller enabled particularly slow? @chinmaygarde

I notice there don't seem to be any iOS or non-impeller regressions so I'm inclined to keep this for now...

@zanderso
Copy link
Member Author

Yeah, if #113770 fixed a real bug, we should keep it. I opened this issue so that we can track that the benchmark recovers as we make progress on the backend for Android.

@chinmaygarde
Copy link
Member

Is clipping on Android with impeller enabled particularly slow?

No, clips should be "free" with the stencil buffers already being present. Perhaps we aren't clearing the render target correctly after the clip causing a load? Should become apparent after profiling. We can keep this open till we get to Android performance. Can we also add a note about the device here this happens on please?

@chinmaygarde chinmaygarde moved this from 🤔 Needs Triage to 🧐 Verification in Impeller Oct 25, 2022
@chinmaygarde chinmaygarde added the engine flutter/engine repository. See also e: labels. label Oct 25, 2022
@chinmaygarde chinmaygarde added P0 Critical issues such as a build break or regression P2 Important issues not at the top of the work list and removed P0 Critical issues such as a build break or regression labels Nov 7, 2022
@zanderso
Copy link
Member Author

It looks like the benchmark recovered, at some point, so I'll close this.

@github-project-automation github-project-automation bot moved this from 🧐 Verification to ✅ Done in Impeller May 23, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chinmaygarde @zanderso @jonahwilliams