Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[NavigationBar] ink ripple positioned is shifted in M3 #117420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TahaTesser opened this issue Dec 20, 2022 · 5 comments · Fixed by #117473
Closed

[NavigationBar] ink ripple positioned is shifted in M3 #117420

TahaTesser opened this issue Dec 20, 2022 · 5 comments · Fixed by #117473
Assignees
@TahaTesser
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version

Comments

@TahaTesser
Copy link
Member

At first, I thought it might be a resolution issue it looks like the ink ripple rendered at a different vertical offset in M3 for some reason.

https://master-api.flutter.dev/flutter/material/NavigationBar-class.html

When running the example as it is without enabling M3, ink is rendered at the right location and you can't see peeking outside but when M3 is enabled, it's slightly off.

Screenshot 2022-12-21 at 01 15 1

Screenshot 2022-12-21 at 01 12
@TahaTesser TahaTesser added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 20, 2022
@TahaTesser TahaTesser self-assigned this Dec 20, 2022
@TahaTesser TahaTesser moved this to To do in Nevercode Dec 20, 2022
@TahaTesser
Copy link
Member Author

cc: @HansMuller
Not sure why the ink ripple is shifted in M3. It might be due to the different label sizes in M2 and M3.
I will fix this with a better a rect.

This was referenced Dec 21, 2022
Merged
Closed
@TahaTesser TahaTesser moved this from To do to PR submitted in Nevercode Jan 11, 2023
@Piinks Piinks added the P2 Important issues not at the top of the work list label Jan 11, 2023
@github-project-automation github-project-automation bot moved this from PR submitted to Done (PR merged) in Nevercode Jan 20, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in Material 3 Jan 20, 2023
@TahaTesser TahaTesser added the r: fixed Issue is closed as already fixed in a newer version label Jan 20, 2023
@w568w w568w mentioned this issue Jan 28, 2023
Closed
@rydmike rydmike mentioned this issue Jan 30, 2023
Closed
@rydmike
Copy link
Contributor

rydmike commented Jan 30, 2023 •
edited
Loading

@TahaTesser and @Piinks,

When you change the height from 80dp, the M3 default, the ink ripple shifts with offset amount up/down equal to height change diff and direction. It affects both M2 and M3 mode. The issue did not exist in stable 3.3 but has now regressed to new stable 3.7.

See example reports coming in here: rydmike/flex_color_scheme#114

I tested in master with the fix PR to this issue present and it fixes it in both M2 and M3 mode, NavigationBar.height can be adjusted without any issues in both M2 and M3.

Maybe consider a CP for the first 3.7 hotfix.

@TahaTesser
Copy link
Member Author

@rydmike
Thanks for the confirmation!

@Piinks Piinks mentioned this issue Jan 30, 2023
Closed
@rydmike
Copy link
Contributor

rydmike commented Feb 2, 2023

Sadly it did not make it into 3.7.1, nor a bunch of other important M3 fixes that exist in master, oh well, later then... 😄

@TahaTesser TahaTesser mentioned this issue Feb 2, 2023
Closed
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TahaTesser TahaTesser

Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version
Projects
Nevercode
Status: Done (PR merged)
Material 3
Status: ✅ Done
Milestone
No milestone
3 participants
@Piinks @rydmike @TahaTesser