-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Let scrollbars avoid obstructing slivers and media query paddings #13253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also avoid media query partial obstructions |
This issue isn't closed yet is it? Since there's still the sliver half of it. |
It was closed because I put partially fixes in my PR. |
We've also run into this problem. We are using a PersistenHeader for our app bar, so it would be good if a solution would not just work with SliverAppBar but can also be used for custom headers. Another note for clarity: In our case we have several slivers below the header that are all scrollable (not just a single |
For future reference: we decided to implement a One thing that makes the |
SO cross-link: I'm wondering is there a workaround for this issue(maybe even in some hacky way)? |
Any update on this ? |
@LongCatIsLooong I remember you started working on the sliver part. Did you have a draft PR or notes from your previous try? |
@xster no unfortunately. |
Any progress? |
Also somewhat relevant for #87370 to avoid drawing the scrollbar on top of pinned header rows, for example. |
any progress? |
I have a proposal for this that should be up for review this week. |
Closing this to consolidate in #107322 I have a proposed solution in #107182 that will fix this consistently across all affected parts of the framework. That PR will be split up into multiple PRs to address each widget that needs this fix, just finishing the many test cases now. Please continue to follow in #107322, I expect all of thees changes to be landing soon. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Uh oh!
There was an error while loading. Please reload this page.
Internal: b/144318472
Consider a CustomScrollView with a SliverAppBar and a SliverList and the user wants a scrollbar showing the position inside the SliverList's contents only.
Let the SliverAppBar report SliverGeometry describing its obstructing and max obstructing extends. Let that get aggregated by the scrollable and bubbled up with a scroll notification so the scrollbar can start below the obstructing area.
The text was updated successfully, but these errors were encountered: