Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[macOS] Refactor FlutterCompositor for testability and add unit tests #137648

Open
@cbracken

Description

@cbracken

The previous FlutterCompositor unit tests were heavily OCMock-based and in fact only really tested two things:

  • that the mock objects we created for the tests do the things we configured them to do.
  • that FlutterCompositor's implementation make certain specific calls to objects that aren't part of its public API.

The first of these isn't useful as a test. The second is testing that the implementation is the implementation rather than testing that the compositor has certain behaviour.

FlutterCompositor should be refactored for testability and new tests written that actually exercise the compositor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: desktopRunning on desktopc: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine repository. See also e: labels.platform-macBuilding on or for macOS specificallyteam-macosOwned by the macOS platform teamtriaged-macosTriaged by the macOS platform team

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions