Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Long-press-drag in text fields only expands correctly in one direction, and the originally selected word should stay highlighted during the expansion #32339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LongCatIsLooong opened this issue May 8, 2019 · 4 comments · Fixed by #113224
Closed

Long-press-drag in text fields only expands correctly in one direction, and the originally selected word should stay highlighted during the expansion #32339

LongCatIsLooong opened this issue May 8, 2019 · 4 comments · Fixed by #113224
Labels
a: fidelity Matching the OEM platforms better a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. found in release: 3.3 Found to occur in 3.3 found in release: 3.5 Found to occur in 3.5 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on r: fixed Issue is closed as already fixed in a newer version

Comments

@LongCatIsLooong
Copy link
Contributor

Steps to Reproduce

Android

  1. Create a TextField
  2. Enter "abc def ghi"
  3. Long press on "e" to highlight "def"
  4. Move the touch point to "h", "def gh" is selected as expected
  5. Move the touch point to "a", the space between "abc" and "def" is selected.

iOS

Double tap drag has not yet been implemented (tracked in #23973), but RenderEditable.selectPositionAt seems to work only in one direction.

Expected:

  1. On both iOS and Android, move the touch point to "a", "abc def" should be selected. Also the initially selected word "def" in step 3 should always stay selected after step 3, regardless of the touch point position .
@LongCatIsLooong LongCatIsLooong added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: fidelity Matching the OEM platforms better f: cupertino flutter/packages/flutter/cupertino repository a: text input Entering text in a text field or keyboard related problems labels May 8, 2019
@LongCatIsLooong LongCatIsLooong mentioned this issue May 8, 2019
Closed
9 tasks
@LongCatIsLooong LongCatIsLooong self-assigned this May 9, 2019
@LongCatIsLooong LongCatIsLooong removed their assignment Jun 9, 2020
@darshankawar
Copy link
Member

Hi @LongCatIsLooong,
Can you please confirm if you still experience this issue on latest Flutter version (eg: dev, master) ?

@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jul 14, 2020
@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Jul 16, 2020 •
edited
Loading

The current behavior has changed but still is still not ideal. It seems I can no longer expand the selection to upstream words. I followed the same steps described in the original comment, and on step 5 the selection won't expand beyond "d". i.e. if the initial selection is "abc def ghi", I can only expand the selection to "abc def ghi" but not "abc def ghi", by long press & drag. Moving the selection handles works as expected.

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jul 16, 2020
@darshankawar darshankawar added found in release: 1.20 Found to occur in 1.20 has reproducible steps The issue has been confirmed reproducible and is ready to work on labels Jul 16, 2020
@Renzo-Olivares Renzo-Olivares mentioned this issue Sep 23, 2022
Merged
8 tasks
@Renzo-Olivares Renzo-Olivares mentioned this issue Oct 10, 2022
Merged
8 tasks
@huycozy
Copy link
Member

huycozy commented Oct 21, 2022

The behavior seems to be the same as mentioned at #32339 (comment) on the latest stable and master channels. I can not move the right touch point to the left to change the selection range (this ability is available on native app). Updating corresponding labels.

flutter doctor -v (stable and master) 
[✓] Flutter (Channel stable, 3.3.5, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.3.5 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d9111f6402 (9 hours ago), 2022-10-19 12:27:13 -0700
    • Engine revision 3ad69d7be3
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.72.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • iPhone 14 Pro Max (mobile) • 332079AF-E895-4685-910E-7B1E18B0C6B8 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 106.0.5249.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.5.0-10.0.pre.17, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.5.0-10.0.pre.17 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 59d26c481a (4 hours ago), 2022-10-20 20:05:08 -0400
    • Engine revision f24ea1a04d
    • Dart version 2.19.0 (build 2.19.0-324.0.dev)
    • DevTools version 2.18.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 106.0.5249.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@huycozy huycozy added found in release: 3.3 Found to occur in 3.3 found in release: 3.5 Found to occur in 3.5 and removed found in release: 1.20 Found to occur in 1.20 labels Oct 21, 2022
@huycozy huycozy added the r: fixed Issue is closed as already fixed in a newer version label Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: fidelity Matching the OEM platforms better a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. found in release: 3.3 Found to occur in 3.3 found in release: 3.5 Found to occur in 3.5 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on r: fixed Issue is closed as already fixed in a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix selectWordsInRange when last word is located before the first word Renzo-Olivares/flutter
3 participants
@LongCatIsLooong @darshankawar @huycozy