Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[google_maps_flutter] [ios] Unpin GoogleMaps cocoapod. #63530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ditman opened this issue Aug 11, 2020 · 9 comments · Fixed by flutter/plugins#3850
Closed

[google_maps_flutter] [ios] Unpin GoogleMaps cocoapod. #63530

ditman opened this issue Aug 11, 2020 · 9 comments · Fixed by flutter/plugins#3850
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: maps Google Maps plugin package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically

Comments

@ditman
Copy link
Member

ditman commented Aug 11, 2020

There seems to be a problem with the GoogleMaps 3.10 cocoapod, requiring XCode 11.4 to compile in an undocumented way.

Our test runners currently use XCode 11.3.1, so when the google_maps_flutter plugin started getting the GoogleMaps 3.10 pod, builds started to fail.

The issue was investigated and mitigated here.

Remove the pin to '<3.10' on google_map_flutter's podspec file once Flutter infra has been updated to XCode 11.4+

(Updates on b/163474612: Comment 4 says that they'll update documentation stating that a new version of XCode is required. Comment 5 says that a workaround is to get XCode 11.4)

@jmagman
Copy link
Member

jmagman commented Aug 12, 2020

Even if they fix in 3.10.1, you will probably never be able to allow 3.10.

@ditman
Copy link
Member Author

ditman commented Aug 12, 2020

I'd expect that once they publish 3.10.1 cocoapod will never resolve to the older 3.10.0?

@jmagman
Copy link
Member

jmagman commented Aug 12, 2020

🤷‍♀️ Depends on if other dependencies use GoogleMaps and their defined ranges. Ideally we should be explicit.

@ditman
Copy link
Member Author

ditman commented Aug 12, 2020

A list of version requirements can be specified for even more fine grained control.

https://guides.cocoapods.org/syntax/podfile.html#pod

I guess it can be something like: '< 3.10', '> 3.10' to "remove" the pin? (while excluding 3.10)

@hectorAguero
Copy link

So, at the time GoogleMaps iOS SDK is in version 4.2.0 and the flutter_package still use the 3.9.0 SDK for iOS, also they announce drop ios 10 support for version 5.0, can the google maps flutter package use the latest iOS SDK?

https://developers.google.com/maps/documentation/ios-sdk/releases

@jmagman
Copy link
Member

jmagman commented May 4, 2021

Flutter 2 still has a minimum of Xcode 11.0, but recommends 12.0.1. In any case, the infra story is past Xcode 12 now.
Maybe the best thing is to totally unpin it, and then users can set pod 'GoogleMaps', '< 3.10' or whatever versions in their own Podfile depending on what Xcode they have installed, their minimum target iOS version, etc...
What do you think, @ditman?

@ditman
Copy link
Member Author

ditman commented May 5, 2021

@jmagman yep, I think it's worth a try. I created this issue while gardening and iOS is not my jam, but this looks safe.

After some time, the 3.10 dependency on a more modern XCode was documented, btw!

Note:

To build apps using the Maps SDK for iOS, the current minimum IDE version supported is Xcode 11.5.

If we're past that, we should be fine, I guess?

@jmagman
Copy link
Member

jmagman commented May 5, 2021

If we're past that, we should be fine, I guess?

Our infra is past that, but the minimum required on Flutter 2 isn't. I think unpinning is probably the best idea since individual users can have control over what GoogleMaps version they use. But if the plugin doesn't unpin, they can't upgrade past 3.9 even if the have the right SDK version installed.

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: maps Google Maps plugin package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants