Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Windows Plugins presubmit is failing on flutter/plugins #69232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amirh opened this issue Oct 28, 2020 · 16 comments
Closed

Windows Plugins presubmit is failing on flutter/plugins #69232

amirh opened this issue Oct 28, 2020 · 16 comments
Assignees
Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team

Comments

@amirh
Copy link
Contributor

amirh commented Oct 28, 2020

New PRs to flutter/plugins are getting a failed "Windows Plugins" presubmit, the cirrus link directs to the flutter dashboard which has no useful information.

Sample PRs with the failure:

This is currently blocking all flutter/plugins PRs.

@amirh amirh added team-infra Owned by Infrastructure team P0 Critical issues such as a build break or regression labels Oct 28, 2020
@godofredoc
Copy link
Contributor

This is because now Windows build_tests are competing for the same bots used by plugins. To fix this problem we need to:

  • First move capacity from the windows 10 machines to windows server.
  • Move all framework-luci devicelab tests to use windows server.
  • Move all framework builds to use windows server.

@keyonghan
Copy link
Contributor

based on competition, shall the plugins builds remain in the queue rather than directly fail?

@godofredoc
Copy link
Contributor

I thought they were failing after a few mins, the ones linked here are failing immediately which means there are 0 Windows Server machines available

@godofredoc
Copy link
Contributor

https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=pool%3Aluci.flutter.try&f=os%3AWindows-Server&k=os&s=id I see machines available.

I would expect long queue time but not seeing failures immediately.

@keyonghan
Copy link
Contributor

Are all these windows bots the same config of 8 cores? We used to have 32 cores bots, which flutter/plugins are currently using.

@godofredoc
Copy link
Contributor

image

The windows machines got downgraded yesterday to use 8 cores. We need to remove the explicit dimension for 32 cores

@keyonghan
Copy link
Contributor

Working on a PR to fix this.

@keyonghan keyonghan self-assigned this Oct 28, 2020
@stuartmorgan-g
Copy link
Contributor

Meta-issue question: can we make the bot status page linked from PRs give useful feedback here (e.g., "Unable to schedule job; zero available machines meet job requirements") instead of a page that just has no information and essentially a link to nowhere?

@keyonghan
Copy link
Contributor

The link in checks page will link to the build details only if the task is scheduled. If failed before being scheduled, the build id will not be available.

Instead if we can obtain the taks id (like 4f86ca6c72bfff10), then it is more useful to have this link.

But as currently supported from cocoon backend, the build is triggered via buildbucket, the task id maybe not available AFAIK.

@keyonghan
Copy link
Contributor

The new config has been propagated. Just retried the failed builds from the above two PRs, and they are running now.

@godofredoc
Copy link
Contributor

Let's open a bug for the usability request there are many of those that we'll need to address once we have the reliability and scalability parts under control.

@keyonghan
Copy link
Contributor

Created issue to track the usability: #69242.

@amirh amirh reopened this Oct 28, 2020
@amirh
Copy link
Contributor Author

amirh commented Oct 28, 2020

This still doesn't seem to be resolved...
flutter/plugins#3213

@amirh
Copy link
Contributor Author

amirh commented Oct 28, 2020

Ohh thanks, that is being worked on as well.

@amirh amirh closed this as completed Oct 28, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
@ricardoamador ricardoamador moved this from Verified to To be archived in [DEPRECATED] Infra Ticket Queue Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team
Projects
No open projects
Development

No branches or pull requests

4 participants